Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

Issue 2254983002: Remove test-only constructor from CreditCard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use the existing utility Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
index 13cc10a646c65aa52dc5e3ac61121b122782e75b..5427082a6eb033ca5361e31194c047c460e16a9f 100644
--- a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
+++ b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
@@ -9,6 +9,7 @@
#include "base/android/context_utils.h"
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "base/guid.h"
#include "base/memory/ptr_util.h"
#include "chrome/browser/ui/android/view_android_helper.h"
#include "chrome/browser/ui/autofill/credit_card_scanner_view_delegate.h"
@@ -73,9 +74,12 @@ void CreditCardScannerViewAndroid::ScanCompleted(
const JavaParamRef<jstring>& card_number,
jint expiration_month,
jint expiration_year) {
- CreditCard card(base::android::ConvertJavaStringToUTF16(env, card_number),
- static_cast<int>(expiration_month), static_cast<int>(expiration_year));
- card.SetRawInfo(CREDIT_CARD_NAME_FULL,
+ CreditCard card(base::GenerateGUID(), std::string());
msw 2016/08/23 18:23:03 optional nit: use default ctor instead and nix bas
please use gerrit instead 2016/08/23 18:42:32 Done.
+ card.SetNumber(base::android::ConvertJavaStringToUTF16(env, card_number));
+ card.SetExpirationMonth(static_cast<int>(expiration_month));
+ card.SetExpirationYear(static_cast<int>(expiration_year));
+ card.SetRawInfo(
+ CREDIT_CARD_NAME_FULL,
base::android::ConvertJavaStringToUTF16(env, card_holder_name));
delegate_->ScanCompleted(card);
}

Powered by Google App Engine
This is Rietveld 408576698