Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2254973006: device/bluetooth: Add a constructor to BluetoothServiceAttributeValueBlueZ (Closed)

Created:
4 years, 4 months ago by Miao
Modified:
4 years, 4 months ago
Reviewers:
rkc, mcchou
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Add a constructor to BluetoothServiceAttributeValueBlueZ This adds a default constructor to bluez::BluetoothServiceAttrivuteValueBlueZ. BUG=b:29314637 Committed: https://crrev.com/5add78e696fdf0edbac2dcf4365b6a90ffe00242 Cr-Commit-Position: refs/heads/master@{#413212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.h View 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mcchou
4 years, 4 months ago (2016-08-19 06:12:33 UTC) #2
rkc
lgtm
4 years, 4 months ago (2016-08-19 19:06:05 UTC) #7
Miao
On 2016/08/19 19:06:05, rkc wrote: > lgtm Thanks.
4 years, 4 months ago (2016-08-19 19:33:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254973006/1
4 years, 4 months ago (2016-08-19 19:33:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 19:38:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 19:41:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5add78e696fdf0edbac2dcf4365b6a90ffe00242
Cr-Commit-Position: refs/heads/master@{#413212}

Powered by Google App Engine
This is Rietveld 408576698