Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.cc

Issue 2254963002: Revert of Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manually create the revert CL Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/shared_worker/shared_worker_service_impl.cc
diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc
index 212028856ad7e3de6af1aa5fd53fb2fa76f40dbc..03b279369e10145bb8b9bf8ecce92152fd5b7b18 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl.cc
@@ -446,15 +446,6 @@ void SharedWorkerServiceImpl::NotifyWorkerDestroyed(int worker_process_id,
WorkerDestroyed(worker_process_id, worker_route_id));
}
-// TODO(alokp): Remove after collecting crash data.
-// Temporary checks to verify that all shared workers are terminated.
-// It is suspected that shared workers prevent render process hosts
-// from shutting down: crbug.com/608049
-void SharedWorkerServiceImpl::CheckAllWorkersTerminated() {
- std::set<int> dependent_renderers = GetRenderersWithWorkerDependency();
- CHECK_EQ(0u, dependent_renderers.size());
-}
-
blink::WebWorkerCreationError
SharedWorkerServiceImpl::ReserveRenderProcessToCreateWorker(
std::unique_ptr<SharedWorkerPendingInstance> pending_instance) {
« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698