Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2254963002: Revert of Check that all shared workers are terminated. (Closed)

Created:
4 years, 4 months ago by manzagop (departed)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, DaleCurtis, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check that all shared workers are terminated. (patchset #1 id:1 of https://codereview.chromium.org/2222063002/ ) Reason for revert: Reverting temporary instrumentation following investigation We want to get this in prior to dev branch. BUG=636377 Original issue's description: > Check that all shared workers are terminated. > > Adds temporary checks to determine whether shared workers > prevent RenderProcessHost(s) from cleaning up due to > RenderProcessHostImpl::worker_ref_count_ > 0. > > BUG=608049 > > Committed: https://crrev.com/529173d1bbeb53b3f9438648fad264b4db042721 > Cr-Commit-Position: refs/heads/master@{#410730} TBR=atwilson@chromium.org,jam@chromium.org,horo@chromium.org,alokp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608049 Committed: https://crrev.com/463ac7e96bf55b106225481811b0db752284bbed Cr-Commit-Position: refs/heads/master@{#412660}

Patch Set 1 #

Patch Set 2 : Manually create the revert CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M content/browser/browser_main_loop.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
manzagop (departed)
Created Revert of Check that all shared workers are terminated.
4 years, 4 months ago (2016-08-17 20:13:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254963002/1
4 years, 4 months ago (2016-08-17 20:13:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-17 20:13:43 UTC) #5
erikchen
lgtm rubber stamp
4 years, 4 months ago (2016-08-17 20:19:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254963002/1
4 years, 4 months ago (2016-08-17 20:39:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/53736) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-17 20:42:15 UTC) #11
manzagop (departed)
The patch failed to apply so I had to manually recreate it.
4 years, 4 months ago (2016-08-17 20:58:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254963002/170001
4 years, 4 months ago (2016-08-17 20:59:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:170001)
4 years, 4 months ago (2016-08-17 22:11:07 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/463ac7e96bf55b106225481811b0db752284bbed Cr-Commit-Position: refs/heads/master@{#412660}
4 years, 4 months ago (2016-08-17 22:14:39 UTC) #19
horo
4 years, 3 months ago (2016-08-27 00:57:45 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:170001) has been created in
https://codereview.chromium.org/2286003002/ by horo@chromium.org.

The reason for reverting is: Shared Worker bug fix patch landed.
https://codereview.chromium.org/2249173003/

BUG=639193.

Powered by Google App Engine
This is Rietveld 408576698