Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2254953002: Rebaseline some CSS align and justify repaint tests (Closed)

Created:
4 years, 4 months ago by Stephen Chennney
Modified:
4 years, 4 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline some CSS align and justify repaint tests The test pixel results are wrong, but that's no reason to keep expectations. We rebaseline for the current result and use the bug to track the fact that we get it wrong. The bug exists in this case and has been updated with the info about these tests. TBR=wangxianzhu@chromium.org BUG=477798, 636475 Committed: https://crrev.com/aa3ce0cd1ae8063be1ec2f6f2444bedce3534aa5 Cr-Commit-Position: refs/heads/master@{#412915}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254953002/1
4 years, 4 months ago (2016-08-17 19:44:57 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-17 21:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254953002/20001
4 years, 4 months ago (2016-08-18 17:47:35 UTC) #6
commit-bot: I haz the power
CQ cannot get SignCLA result. Please try later.
4 years, 4 months ago (2016-08-18 18:32:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254953002/20001
4 years, 4 months ago (2016-08-18 18:48:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 19:41:47 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:44:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa3ce0cd1ae8063be1ec2f6f2444bedce3534aa5
Cr-Commit-Position: refs/heads/master@{#412915}

Powered by Google App Engine
This is Rietveld 408576698