Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2254933003: Convert editing/deleting/delete-block-merge-contents-0{18,19,20,21}.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-block-merge-contents-0{18,19,20,21}.html to use w3c test harness This patch converts "editing/deleting/delete-block-merge-contents-0{18,19,20,21}.html" to use w3c test harness to simplify test script for improving readability, and consolidates into "delete_block_merge_end_of_line.html" since samples of them are similar. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/fe6da08d78aa26381effc626b952023a99a5da93 Cr-Commit-Position: refs/heads/master@{#412794}

Patch Set 1 : 2016-08-18T14:44:04 #

Patch Set 2 : 2016-08-18T17:11:17 #

Total comments: 4

Patch Set 3 : 2016-08-18T18:17:54 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -499 lines) Patch
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-018.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-019.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-020.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-021.html View 1 chunk +0 lines, -52 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-018-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-018-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-019-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-019-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-020-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-020-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-021-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-021-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-018-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-019-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-020-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-021-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-018-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-018-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-019-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-019-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-020-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-020-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-021-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-021-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-18 07:09:55 UTC) #5
Xiaocheng
Only three test cases for four test files?
4 years, 4 months ago (2016-08-18 07:55:16 UTC) #8
yosin_UTC9
On 2016/08/18 at 07:55:16, xiaochengh wrote: > Only three test cases for four test files? ...
4 years, 4 months ago (2016-08-18 08:30:09 UTC) #9
Xiaocheng
https://codereview.chromium.org/2254933003/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html File third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html (right): https://codereview.chromium.org/2254933003/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html#newcode22 third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html:22: test(() => assert_selection( This doesn't seem to be the ...
4 years, 4 months ago (2016-08-18 09:01:41 UTC) #10
yosin_UTC9
PTAL https://codereview.chromium.org/2254933003/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html File third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html (right): https://codereview.chromium.org/2254933003/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html#newcode22 third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_end_of_line.html:22: test(() => assert_selection( On 2016/08/18 at 09:01:40, Xiaocheng ...
4 years, 4 months ago (2016-08-18 09:21:34 UTC) #13
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-18 09:25:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254933003/40001
4 years, 4 months ago (2016-08-18 09:48:25 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 10:49:18 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:51:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe6da08d78aa26381effc626b952023a99a5da93
Cr-Commit-Position: refs/heads/master@{#412794}

Powered by Google App Engine
This is Rietveld 408576698