Reuse NativeThemeAuraDark for cros tray.

ash/common/system/date/date_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/date/date_view.h"
 
 #include "ash/common/system/tray/system_tray_delegate.h"
 #include "ash/common/system/tray/tray_constants.h"
 #include "ash/common/system/tray/tray_utils.h"
 #include "ash/common/wm_shell.h"
@@ skipping 53 matching lines @@
   icu::SimpleDateFormat simple_formatter(generated_pattern, status);
   DCHECK(U_SUCCESS(status));
   icu::UnicodeString date_string;
   simple_formatter.format(static_cast<UDate>(time.ToDoubleT() * 1000),
                           date_string, status);
   DCHECK(U_SUCCESS(status));
   return base::string16(date_string.getBuffer(),
                         static_cast<size_t>(date_string.length()));
 }
 
-views::Label* CreateLabel() {
-  views::Label* label = new views::Label;
-  label->SetHorizontalAlignment(gfx::ALIGN_LEFT);

[Evan Stade, 2016/08/18 00:38:02]

This alignment is not necessary for the time labels.

The background color is neither necessary nor correct for the time labels (they
don't have auto color readability, and the bg color is set in
SetupLabelForTray). The background color/auto readability adjustments is not
necessary for the date label either, which automatically has a light bg color
set. The 0 opacity disabled subpixel rendering, which is not necessary since the
date label is displayed on a solid bg.

-  label->SetBackgroundColor(SkColorSetARGB(0, 255, 255, 255));
-  return label;
-}
-
 }  // namespace
 
 BaseDateTimeView::~BaseDateTimeView() {
   timer_.Stop();
 }
 
 void BaseDateTimeView::UpdateText() {
   base::Time now = base::Time::Now();
   UpdateTextInternal(now);
   SchedulePaint();
@@ skipping 47 matching lines @@
 }
 
 void BaseDateTimeView::OnLocaleChanged() {
   UpdateText();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 DateView::DateView() : action_(TrayDate::NONE) {
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
-  date_label_ = CreateLabel();
+  date_label_ = new views::Label();
+  date_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   date_label_->SetEnabledColor(kHeaderTextColorNormal);
   UpdateTextInternal(base::Time::Now());
   AddChildView(date_label_);
 }
 
 DateView::~DateView() {}
 
 void DateView::SetAction(TrayDate::DateAction action) {
   if (action == action_)
     return;
@@ skipping 149 matching lines @@
 void TimeView::SetBorderFromLayout(TrayDate::ClockLayout clock_layout) {
   if (clock_layout == TrayDate::HORIZONTAL_CLOCK)
     SetBorder(views::Border::CreateEmptyBorder(
         0, kTrayLabelItemHorizontalPaddingBottomAlignment, 0,
         kTrayLabelItemHorizontalPaddingBottomAlignment));
   else
     SetBorder(views::Border::NullBorder());
 }
 
 void TimeView::SetupLabels() {
-  horizontal_label_.reset(CreateLabel());
+  horizontal_label_.reset(new views::Label());
   SetupLabel(horizontal_label_.get());
-  vertical_label_hours_.reset(CreateLabel());
+  vertical_label_hours_.reset(new views::Label());
   SetupLabel(vertical_label_hours_.get());
-  vertical_label_minutes_.reset(CreateLabel());
+  vertical_label_minutes_.reset(new views::Label());
   SetupLabel(vertical_label_minutes_.get());
+  // TODO(estade): this should use the NativeTheme's secondary text color.
   vertical_label_minutes_->SetEnabledColor(kVerticalClockMinuteColor);
   // Pull the minutes up closer to the hours by using a negative top border.
   vertical_label_minutes_->SetBorder(views::Border::CreateEmptyBorder(
       kVerticalClockMinutesTopOffset, 0, 0, 0));
 }
 
 void TimeView::SetupLabel(views::Label* label) {
   label->set_owned_by_client();
   SetupLabelForTray(label);
   label->SetElideBehavior(gfx::NO_ELIDE);
 }
 
 }  // namespace tray
 }  // namespace ash