Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: extensions/common/url_pattern_unittest.cc

Issue 225493002: cleanup: cpplint src/extension/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern_set_unittest.cc ('k') | extensions/common/user_script_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern_unittest.cc
diff --git a/extensions/common/url_pattern_unittest.cc b/extensions/common/url_pattern_unittest.cc
index d1cc8c2103cccf01561f9723471b1ffe580bc4e6..3e0c816ac35ec2d82a15a5814ed43241b3002d87 100644
--- a/extensions/common/url_pattern_unittest.cc
+++ b/extensions/common/url_pattern_unittest.cc
@@ -55,7 +55,7 @@ TEST(ExtensionURLPatternTest, Ports) {
{ "http://foo:1234/", URLPattern::PARSE_SUCCESS, "1234" },
{ "http://foo:1234/bar", URLPattern::PARSE_SUCCESS, "1234" },
{ "http://*.foo:1234/", URLPattern::PARSE_SUCCESS, "1234" },
- { "http://*.foo:1234/bar", URLPattern::PARSE_SUCCESS,"1234" },
+ { "http://*.foo:1234/bar", URLPattern::PARSE_SUCCESS, "1234" },
{ "http://:1234/", URLPattern::PARSE_SUCCESS, "1234" },
{ "http://foo:/", URLPattern::PARSE_ERROR_INVALID_PORT, "*" },
{ "http://foo:*/", URLPattern::PARSE_SUCCESS, "*" },
@@ -69,7 +69,7 @@ TEST(ExtensionURLPatternTest, Ports) {
// Port-like strings in the path should not trigger a warning.
{ "http://*/:1234", URLPattern::PARSE_SUCCESS, "*" },
{ "http://*.foo/bar:1234", URLPattern::PARSE_SUCCESS, "*" },
- { "http://foo/bar:1234/path", URLPattern::PARSE_SUCCESS,"*" },
+ { "http://foo/bar:1234/path", URLPattern::PARSE_SUCCESS, "*" },
};
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestPatterns); ++i) {
@@ -380,7 +380,8 @@ TEST(ExtensionURLPatternTest, Match17) {
EXPECT_FALSE(pattern.MatchesURL(GURL("http://www.example.com:8080/foo")));
EXPECT_FALSE(pattern.MatchesURL(
GURL("filesystem:http://www.example.com:8080/foo/")));
- EXPECT_FALSE(pattern.MatchesURL(GURL("filesystem:http://www.example.com/f/foo")));
+ EXPECT_FALSE(pattern.MatchesURL(
+ GURL("filesystem:http://www.example.com/f/foo")));
}
// Explicit port wildcard
« no previous file with comments | « extensions/common/url_pattern_set_unittest.cc ('k') | extensions/common/user_script_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698