Issue 225493002: cleanup: cpplint src/extension/*

Issue 225493002: cleanup: cpplint src/extension/* (Closed)

Created:
6 years, 8 months ago by limasdf

Modified:
6 years, 8 months ago

Reviewers:
Devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cleanup: cpplint src/extension/* no logical change. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262356

Patch Set 2 : Address review comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
M	extensions/browser/renderer_startup_helper.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/browser/view_type_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/view_type_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/crx_file.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/common/csp_validator.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/common/extension_api.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/extension_messages.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/stack_frame.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/switches.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/url_pattern_set.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	extensions/common/url_pattern_set_unittest.cc	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	extensions/common/url_pattern_unittest.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	extensions/common/user_script_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	extensions/common/value_builder.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Devlin

Good cleanup work! A few small nits. https://codereview.chromium.org/225493002/diff/1/extensions/browser/extension_system.h File extensions/browser/extension_system.h (right): https://codereview.chromium.org/225493002/diff/1/extensions/browser/extension_system.h#newcode19 extensions/browser/extension_system.h:19: } // ...

6 years, 8 months ago (2014-04-07 17:10:02 UTC) #2

limasdf

Thanks for the review! PTAL https://codereview.chromium.org/225493002/diff/1/extensions/browser/extension_system.h File extensions/browser/extension_system.h (right): https://codereview.chromium.org/225493002/diff/1/extensions/browser/extension_system.h#newcode19 extensions/browser/extension_system.h:19: } // namespace chromeos ...

6 years, 8 months ago (2014-04-08 01:36:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/225493002/20001

6 years, 8 months ago (2014-04-08 05:07:52 UTC) #6

Message was sent while issue was closed.

Change committed as 262356

Expand Messages | Collapse Messages