Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2254913002: SkLiteDL: a little spring cleaning (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL: a little spring cleaning - kill off optimizeFor() now that we know it's broken and have a better way; - simplify makeThreadsafe() a bit: we're not calling it anyway. This sort of earns me back some crazy code currency, which I am going to try to spend making reset() faster. If anything, this appears to make makeThreadsafe() _faster_. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254913002 Committed: https://skia.googlesource.com/skia/+/91cd2803e78c876bc8eac07480465d9bf8457786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -62 lines) Patch
M src/core/SkLiteDL.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkLiteDL.cpp View 27 chunks +6 lines, -59 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
mtklein_C
4 years, 4 months ago (2016-08-17 17:49:13 UTC) #8
djsollen
lgtm
4 years, 4 months ago (2016-08-17 18:38:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254913002/1
4 years, 4 months ago (2016-08-17 18:38:34 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:39:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/91cd2803e78c876bc8eac07480465d9bf8457786

Powered by Google App Engine
This is Rietveld 408576698