Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 22549003: Fix -Wconversion warnings in external V8 headers. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Fix -Wconversion warnings in external V8 headers. BUG=v8:2830 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M include/v8.h View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 4 months ago (2013-08-09 07:23:17 UTC) #1
Sven Panne
lgtm
7 years, 4 months ago (2013-08-09 10:28:09 UTC) #2
Benedikt Meurer
7 years, 4 months ago (2013-08-09 10:33:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16127 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698