Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2254893012: Give the password list a CrScrollableBehavior to allow refresh to work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use an observer Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
index e8da6159cd3e9a48f63e7fbc7976b8ad5873a8de..41dead3e9361faf9034482f052e29a45cce8d1f3 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
@@ -20,6 +20,8 @@ var ExceptionPairEntryEvent;
Polymer({
is: 'passwords-section',
+ behaviors: [CrScrollableBehavior],
+
properties: {
/** Preferences state. */
prefs: {
@@ -71,6 +73,16 @@ Polymer({
'passwordList.scroll': 'closeMenu_',
},
+ observers: ['passwordListChanged_(savedPasswords, filter)'],
+
+ /**
+ * Updates the scrollable contents when the list of passwords has changed.
+ * @private
+ */
+ passwordListChanged_: function() {
+ this.updateScrollableContents();
+ },
+
/**
* Sets the password in the current password dialog if the loginPair matches.
* @param {!chrome.passwordsPrivate.LoginPair} loginPair
« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698