third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2254893005: Fix visual rect for background box painting in composited scrollers.

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2254893005: Fix visual rect for background box painting in composited scrollers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Invalidate scrolling contents layer and mark paint layer setNeedsRepaint. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-local-background.html ('K') | « third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-local-background-expected.txt ('k') | third_party/WebKit/Source/core/paint/BoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index a6f845941eaaee947c68515fe29fc3273ab92a03..d83f1633504c0f04c338ede0370b2395be6c27fd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -439,6 +439,8 @@ void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe

// rather than updating the entire rect.

const LayoutRect& scrollingContentsRect = toLayoutBox(this)->layoutOverflowRect();

layer()->compositedLayerMapping()->setScrollingContentsNeedDisplayInRect(scrollingContentsRect, invalidationReason, object);

+ layer()->setNeedsRepaint();

wkorman 2016/08/18 23:48:11 We need this due to subsequent invalidateDisplayIt

Stephen Chennney 2016/08/19 18:10:43 I can't answer that. Not sure who can.

+ invalidateDisplayItemClient(*layer()->compositedLayerMapping()->scrollingContentsLayer(), invalidationReason);

wkorman 2016/08/18 23:48:11 We need this to pair with the use of the scrolling

}

layer()->compositedLayerMapping()->setNonScrollingContentsNeedDisplayInRect(r, invalidationReason, object);

} else {