third_party/WebKit/LayoutTests/fast/scroll-behavior/overflow-scroll-with-local-background-and-text.html - Issue 2254893005: Fix visual rect for background box painting in composited scrollers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scroll-behavior/overflow-scroll-with-local-background-and-text.html

Issue 2254893005: Fix visual rect for background box painting in composited scrollers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Invalidate scrolling contents layer and mark paint layer setNeedsRepaint. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-local-background-text-color-change.html ('K') | « third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-local-background-text-color-change-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/scroll-behavior/overflow-scroll-with-local-background-and-text-expected.html » ('j') | third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-local-background.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.waitUntilDone();

	5

	6 onload = function() {
	wkorman 2016/08/18 23:48:11 This is test case from flackr@ via http://crbug.co This is test case from flackr@ via http://crbug.com/638611 basically as-provided. I think the new-fangled thing to do is use runAfterLayoutAndPaint() below rather than double-rAF but either seems ok. The border in #scroller is also potentially extraneous.
	7 // Double rAF to ensure content is painted before scroll.

	8 requestAnimationFrame(function() {

	9 requestAnimationFrame(scrollToBottom);

	10 });

	11 }

	12

	13 function scrollToBottom() {

	14 scroller.scrollTop = 500;

	15 if (window.testRunner)

	16 window.testRunner.notifyDone();

	17 }

	18 </script>

	19 <style>

	20 #scroller {

	21 background: gray local;

	22 border: 10px solid green;

	23 overflow: scroll;

	24 width: 200px;

	25 height: 200px;

	26 will-change: transform;

	27 }

	28

	29 #spacer {

	30 height: 500px;

	31 }

	32 </style>

	33 <!-- Test that the background is correctly repainted when the scrolled content

	34 grows in size. -->

	35 <div id="scroller">

	36 <div id="spacer"></div>

	37 <p>Text content</p>

	38 </div>

OLD	NEW