Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: pkg/analyzer/test/src/summary/pub_summary_test.dart

Issue 2254893003: Add PubSummaryManager.computeUnlinkedForFolder() for Flutter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/analyzer/pubspec.yaml ('K') | « pkg/analyzer/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/pub_summary_test.dart
diff --git a/pkg/analyzer/test/src/summary/pub_summary_test.dart b/pkg/analyzer/test/src/summary/pub_summary_test.dart
index ef6b2a7c1207ffcd64adfdf4c1c62da3c1646be7..430c48981a0046637ec5e5150b74292e705bd8b5 100644
--- a/pkg/analyzer/test/src/summary/pub_summary_test.dart
+++ b/pkg/analyzer/test/src/summary/pub_summary_test.dart
@@ -4,7 +4,6 @@
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/source/package_map_resolver.dart';
-import 'package:analyzer/src/generated/sdk.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/summary/format.dart';
import 'package:analyzer/src/summary/idl.dart';
@@ -148,6 +147,41 @@ class B {}
}
}
+ test_computeUnlinkedForFolder() async {
+ // Create package files.
+ resourceProvider.newFile(
+ '/flutter/aaa/lib/a.dart',
+ '''
+class A {}
+''');
+ resourceProvider.newFile(
+ '/flutter/bbb/lib/b.dart',
+ '''
+class B {}
+''');
+
+ // Configure packages resolution.
+ Folder libFolderA = resourceProvider.newFolder('/flutter/aaa/lib');
+ Folder libFolderB = resourceProvider.newFolder('/flutter/bbb/lib');
+ context.sourceFactory = new SourceFactory(<UriResolver>[
+ sdkResolver,
+ resourceResolver,
+ new PackageMapUriResolver(resourceProvider, {
+ 'aaa': [libFolderA],
+ 'bbb': [libFolderB],
+ })
+ ]);
+
+ await manager.computeUnlinkedForFolder('aaa', libFolderA);
+ await manager.computeUnlinkedForFolder('bbb', libFolderB);
+
+ // The files must be created.
+ _assertFileExists(libFolderA.parent, PubSummaryManager.UNLINKED_NAME);
+ _assertFileExists(libFolderA.parent, PubSummaryManager.UNLINKED_SPEC_NAME);
+ _assertFileExists(libFolderB.parent, PubSummaryManager.UNLINKED_NAME);
+ _assertFileExists(libFolderB.parent, PubSummaryManager.UNLINKED_SPEC_NAME);
+ }
+
test_getLinkedBundles_cached() async {
String pathA1 = '$CACHE/aaa-1.0.0';
String pathA2 = '$CACHE/aaa-2.0.0';
@@ -1231,16 +1265,6 @@ class B {}
manager = new PubSummaryManager(resourceProvider, '_.temp');
}
- List<File> _getLinkedFiles(Folder folder) {
- List<File> linkedFiles = <File>[];
- for (var child in folder.getChildren()) {
- if (child is File && child.shortName.startsWith('linked_')) {
- linkedFiles.add(child);
- }
- }
- return linkedFiles;
- }
-
LinkedPubPackage _getLinkedPackage(
List<LinkedPubPackage> packages, String name) {
return packages
« pkg/analyzer/pubspec.yaml ('K') | « pkg/analyzer/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698