Issue 2254893003: Add PubSummaryManager.computeUnlinkedForFolder() for Flutter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2254893003: Add PubSummaryManager.computeUnlinkedForFolder() for Flutter. (Closed)

Created:
4 years, 4 months ago by scheglov

Modified:
4 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add PubSummaryManager.computeUnlinkedForFolder() for Flutter. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5bfd6e6dbb11e473800d799f8e3cb0a0e7854082

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -15 lines)			Patch
M	pkg/analyzer/lib/src/summary/pub_summary.dart	View	5 chunks	+26 lines, -4 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	pkg/analyzer/test/src/summary/pub_summary_test.dart	View	3 chunks	+35 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2254893003/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/2254893003/diff/1/pkg/analyzer/pubspec.yaml#newcode21 pkg/analyzer/pubspec.yaml:21: meta: ^1.0.2 This is being used in "lib/src/summary/pub_summary.dart", ...

4 years, 4 months ago (2016-08-17 20:37:29 UTC) #2

scheglov

4 years, 4 months ago (2016-08-17 21:31:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5bfd6e6dbb11e473800d799f8e3cb0a0e7854082 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages