test/codegen/lib/convert/ascii_test.dart - Issue 2254883002: roll analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/codegen/lib/convert/ascii_test.dart

Issue 2254883002: roll analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/codegen/lib/convert/ascii_test.dart

diff --git a/test/codegen/lib/convert/ascii_test.dart b/test/codegen/lib/convert/ascii_test.dart

index c8d1b66522ffba1405d1935d98a338cd56c93917..4d5dfddf7eeb7749d5cbe6d6d29bc64080c99884 100644

--- a/test/codegen/lib/convert/ascii_test.dart

+++ b/test/codegen/lib/convert/ascii_test.dart

@@ -91,8 +91,7 @@ void testDirectConversions() {

List<int> encode(String str, int chunkSize,

Converter<String, List<int>> converter) {

List<int> bytes = <int>[];

- ChunkedConversionSink byteSink =

- new ByteConversionSink.withCallback(bytes.addAll);

+ var byteSink = new ByteConversionSink.withCallback(bytes.addAll);

var stringConversionSink = converter.startChunkedConversion(byteSink);

for (int i = 0; i < str.length; i += chunkSize) {

if (i + chunkSize <= str.length) {