Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2254883002: roll analyzer (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 3

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -51 lines) Patch
M lib/runtime/dart_sdk.js View 1 9 chunks +9 lines, -10 lines 0 comments Download
M pubspec.lock View 1 2 8 chunks +15 lines, -9 lines 0 comments Download
M pubspec.yaml View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M test/codegen/lib/convert/ascii_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf82_test.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf83_test.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf85_test.dart View 1 7 chunks +7 lines, -7 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf86_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf87_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/codegen/lib/convert/chunked_conversion_utf89_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/lib/convert/latin1_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-18 00:41:31 UTC) #2
vsm
https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml#newcode11 pubspec.yaml:11: analyzer: ^0.27.5-alpha.0 Why an override below instead of up ...
4 years, 4 months ago (2016-08-18 03:40:28 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml#newcode11 pubspec.yaml:11: analyzer: ^0.27.5-alpha.0 On 2016/08/18 03:40:28, vsm wrote: > Why ...
4 years, 4 months ago (2016-08-18 03:43:43 UTC) #4
vsm
lgtm https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2254883002/diff/20001/pubspec.yaml#newcode11 pubspec.yaml:11: analyzer: ^0.27.5-alpha.0 On 2016/08/18 03:43:43, John Messerly wrote: ...
4 years, 4 months ago (2016-08-18 03:49:55 UTC) #5
Jennifer Messerly
4 years, 4 months ago (2016-08-18 04:10:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5e7cd10599cd82ca1361ce65b0d7e961eea29365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698