Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2254863002: Revert of Android: Make the spare renderer accessible to all Chrome tabs. (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
Yusuf, Benoit L, Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Make the spare renderer accessible to all Chrome tabs. (patchset #7 id:120001 of https://codereview.chromium.org/2199393002/ ) Reason for revert: New test WarmupManagerTest#testCreateAndTakeSpareRenderer failing on 3 different bots: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35784 https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester/builds/5165 https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5527 Original issue's description: > Android: Make the spare renderer accessible to all Chrome tabs. > > In Custom Tabs, an external application can "warm up" Chrome. This > creates and initializes a spare renderer, and has been found to be a > significant optimization for loading performance. > > This patch moves the spare renderer logic out of Custom Tabs, and makes > it accessible and useful for regular navigations in Chrome. Note that > this patch doesn't add new call sites for the spare renderer creation. > > BUG=633964 > > Committed: https://crrev.com/f7ce563033df1df90b314e4f727596c93c2b3d6d > Cr-Commit-Position: refs/heads/master@{#412510} TBR=yusufo@chromium.org,mariakhomenko@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633964 Committed: https://crrev.com/433ebba49c7a42eeab9806d40f4d5949b359be32 Cr-Commit-Position: refs/heads/master@{#412565}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of Android: Make the spare renderer accessible to all Chrome tabs.
4 years, 4 months ago (2016-08-17 17:02:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254863002/1
4 years, 4 months ago (2016-08-17 17:02:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 17:03:20 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:05:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433ebba49c7a42eeab9806d40f4d5949b359be32
Cr-Commit-Position: refs/heads/master@{#412565}

Powered by Google App Engine
This is Rietveld 408576698