Add git_bootstrap.py, which bootstraps git on Windows using CIPD

Add git_bootstrap.py, which bootstraps git on Windows using CIPD

It's backwards compatible with the logic in win_tools.bat
and is intended to eventually replace it.

BUG=635421, 629679
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d0a5acdc43f959770d844a3ccb8bc3a5ad9afb6

[Paweł Hajdan Jr., 2016-08-18 10:25:47]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 10:25:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 10:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:31:25]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-08-18 10:36:21]

phajdan.jr@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-08-18 18:45:39]

lgtm

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap.py
File bootstrap/win/git_bootstrap.py (right):

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:39: for entry in
fnmatch.filter(os.listdir(ROOT_DIR), 'git-*_bin'):
I think you just want to use the glob library:
https://docs.python.org/2/library/glob.html

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:51: 'bootstrap.py'),
Let's add a comment in this bootstrap.py file to mention that it's called from
outside recipes. It's probably OK to leave it in this folder for now.

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:52: '--platform', 'windows-amd64',
why doesn't bootstrap.py automatically compute this?

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:126: '-Directory="%s"' %
git_directory.replace('\\', '\\\\'),
if you use raw strings, you can halve the number of slashes here

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:142: f.write(git_template.replace('GIT_PROGRAM',
'usr\\bin\\ssh-keygen.exe'))
can we make this a loop over e.g. a list of tuples? I would have done this in
the batchfile, but... well... it's a batchfile :)

https://codereview.chromium.org/2254843004/diff/1/bootstrap/win/git_bootstrap...
bootstrap/win/git_bootstrap.py:165: stdout=DEVNULL)
this is a bit janky (it should probably not shell out to xcopy), but xcopy does
have nice copy-if-different semantics. Maybe just add a TODO?

[Paweł Hajdan Jr., 2016-08-18 19:23:17]

phajdan.jr@chromium.org changed reviewers:
+ phajdan@google.com

[Paweł Hajdan Jr., 2016-08-18 19:23:18]

We've chatted over IM and I believe I addressed what could be addressed.

There are opportunities for follow-up CLs to make cipd/resources/bootstrap.py
easier to use.

If there's anyone I might have missed, please just let me know.

[Paweł Hajdan Jr., 2016-08-18 19:23:26]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-08-18 19:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2254843004/#ps20001
(title: "fixes")

[commit-bot: I haz the power, 2016-08-18 19:23:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:26:53]

Description was changed from

==========
Add git_bootstrap.py, which bootstraps git on Windows using CIPD

It's backwards compatible with the logic in win_tools.bat
and is intended to eventually replace it.

BUG=635421, 629679
==========

to

==========
Add git_bootstrap.py, which bootstraps git on Windows using CIPD

It's backwards compatible with the logic in win_tools.bat
and is intended to eventually replace it.

BUG=635421, 629679

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d0a5acdc43f95...
==========

[commit-bot: I haz the power, 2016-08-18 19:26:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d0a5acdc43f95...