[css-grid] Avoid computing twice the number of auto-repeat columns

[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

Committed: https://crrev.com/49bc5ba13c492f09971882e2cb842e3514d19922
Cr-Commit-Position: refs/heads/master@{#412638}

[Manuel Rego, 2016-08-17 16:57:10]

Description was changed from

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch uses computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoid the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html
==========

to

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html
==========

[Manuel Rego, 2016-08-17 17:19:04]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org, jfernandez@igalia.com

[Manuel Rego, 2016-08-17 17:19:05]

Probably this needs further investigation but this patch avoids the crash
and doesn't seem harmful.

[cbiesinger, 2016-08-17 17:25:53]

lgtm, thanks!

[Manuel Rego, 2016-08-17 19:34:13]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-08-17 19:34:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:15:12]

Description was changed from

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html
==========

to

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html
==========

[commit-bot: I haz the power, 2016-08-17 21:15:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 21:17:57]

Description was changed from

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html
==========

to

==========
[css-grid] Avoid computing twice the number of auto-repeat columns

During the track sizing layout, we were computing twice the number
of auto-repeat columns.
That was causing crashes on debug and ASAN builds.
The patch computes the value once and pass it to
LayoutGrid::placeItemsOnGrid(), which avoids the issue.

Add new cases that were crashing to test introduced in r405529.

BUG=633474
TBR=svillar@igalia.com
TEST=fast/css-grid-layout/grid-indefinite-size-auto-repeat-crash.html

Committed: https://crrev.com/49bc5ba13c492f09971882e2cb842e3514d19922
Cr-Commit-Position: refs/heads/master@{#412638}
==========

[commit-bot: I haz the power, 2016-08-17 21:17:58]

Patchset 1 (id:??) landed as
https://crrev.com/49bc5ba13c492f09971882e2cb842e3514d19922
Cr-Commit-Position: refs/heads/master@{#412638}

[eae, 2016-08-18 02:18:42]

Thank you!