Rebaseline svg/custom/foreign-object-skew.svg on Mac

Rebaseline svg/custom/foreign-object-skew.svg on Mac

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG=390488, 636475
Committed: https://crrev.com/69de2a35ac6db47eb5994b21dbbab8eecf8f3990
Cr-Commit-Position: refs/heads/master@{#412583}

[Stephen Chennney, 2016-08-17 16:31:45]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 16:32:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen Chennney, 2016-08-17 16:32:08]

PTAL.

[f(malita), 2016-08-17 16:43:44]

LGTM, but please double-check that the diff is not indicative of a more serious
problem: looking at
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...,
it seems some of the diffs show a missing gradient.  Maybe that's just the
UI/theme changing while this test was disabled?

[Stephen Chennney, 2016-08-17 16:52:12]

On 2016/08/17 16:43:44, f(malita) wrote:
> LGTM, but please double-check that the diff is not indicative of a more
serious
> problem: looking at
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...,
> it seems some of the diffs show a missing gradient.  Maybe that's just the
> UI/theme changing while this test was disabled?

Good point. Though I am still loath to care. I seem to recall that the layout
tests use a theme that is not used in production, so users never see this. I'll
check what it looks like in stable just to be sure we're not breaking the web.

[Stephen Chennney, 2016-08-17 17:08:23]

On 2016/08/17 16:52:12, Stephen Chennney wrote:
> On 2016/08/17 16:43:44, f(malita) wrote:
> > LGTM, but please double-check that the diff is not indicative of a more
> serious
> > problem: looking at
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...,
> > it seems some of the diffs show a missing gradient.  Maybe that's just the
> > UI/theme changing while this test was disabled?
> 
> Good point. Though I am still loath to care. I seem to recall that the layout
> tests use a theme that is not used in production, so users never see this.
I'll
> check what it looks like in stable just to be sure we're not breaking the web.

The result in Mac stable is the same as the test, and looks the same (within
reason) as the result without any skew. That's good enough for me to accept the
new results.

[f(malita), 2016-08-17 17:09:01]

On 2016/08/17 17:08:23, Stephen Chennney wrote:
> On 2016/08/17 16:52:12, Stephen Chennney wrote:
> > On 2016/08/17 16:43:44, f(malita) wrote:
> > > LGTM, but please double-check that the diff is not indicative of a more
> > serious
> > > problem: looking at
> > >
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...,
> > > it seems some of the diffs show a missing gradient.  Maybe that's just the
> > > UI/theme changing while this test was disabled?
> > 
> > Good point. Though I am still loath to care. I seem to recall that the
layout
> > tests use a theme that is not used in production, so users never see this.
> I'll
> > check what it looks like in stable just to be sure we're not breaking the
web.
> 
> The result in Mac stable is the same as the test, and looks the same (within
> reason) as the result without any skew. That's good enough for me to accept
the
> new results.

SGTM, thanks for checking.

[commit-bot: I haz the power, 2016-08-17 17:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 17:45:37]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2016-08-17 17:59:24]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2016-08-17 17:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:04:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 18:09:46]

Description was changed from

==========
Rebaseline svg/custom/foreign-object-skew.svg on Mac

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG=390488,636475
==========

to

==========
Rebaseline svg/custom/foreign-object-skew.svg on Mac

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG=390488,636475

Committed: https://crrev.com/69de2a35ac6db47eb5994b21dbbab8eecf8f3990
Cr-Commit-Position: refs/heads/master@{#412583}
==========

[commit-bot: I haz the power, 2016-08-17 18:09:48]

Patchset 1 (id:??) landed as
https://crrev.com/69de2a35ac6db47eb5994b21dbbab8eecf8f3990
Cr-Commit-Position: refs/heads/master@{#412583}