Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2254813003: Update Android owners for base to always refer to files (Closed)

Created:
4 years, 4 months ago by nyquist
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Android owners for base to always refer to files Instead of listing the Android owners of //base/android and //base/test/android in several GN-files, just refer to their canonical location. This CL also adds Android owners to approve changes to //base/test/*android* files and the //base/test/BUILD.gn file. BUG=None Committed: https://crrev.com/c311f4696c6fab55ccee7d37efa1e6a021bdafba Cr-Commit-Position: refs/heads/master@{#412679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M base/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
M base/test/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nyquist
danakj: PTAL
4 years, 4 months ago (2016-08-17 21:33:07 UTC) #3
danakj
LGTM
4 years, 4 months ago (2016-08-17 22:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254813003/1
4 years, 4 months ago (2016-08-17 22:14:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 22:57:44 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:16:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c311f4696c6fab55ccee7d37efa1e6a021bdafba
Cr-Commit-Position: refs/heads/master@{#412679}

Powered by Google App Engine
This is Rietveld 408576698