[wasm] Throw a type error if an I64 is exported to JS.

[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows

Committed: https://crrev.com/92b7c728e20e7a7f1ef452322c7295bbaa421704
Cr-Commit-Position: refs/heads/master@{#38718}

[ahaas, 2016-08-17 15:22:41]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:22:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-17 15:48:16]

ahaas@chromium.org changed reviewers:
+ bgeron@google.com

[ahaas, 2016-08-17 15:49:05]

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2207: return
BuildCallToRuntime(Runtime::kWasmThrowTypeError, jsgraph(),
Do I need a IfSuccess node here?

[titzer, 2016-08-17 15:49:53]

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2207: return
BuildCallToRuntime(Runtime::kWasmThrowTypeError, jsgraph(),
On 2016/08/17 15:49:04, ahaas wrote:
> Do I need a IfSuccess node here?

No, only if there is a catch handler in the current graph.

[commit-bot: I haz the power, 2016-08-17 16:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:00:36]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-08-18 11:02:45]

On 2016/08/17 at 15:49:53, titzer wrote:
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:2207: return
BuildCallToRuntime(Runtime::kWasmThrowTypeError, jsgraph(),
> On 2016/08/17 15:49:04, ahaas wrote:
> > Do I need a IfSuccess node here?
> 
> No, only if there is a catch handler in the current graph.

And no, because no node is generated which is used as a control input for some
other node.

[titzer, 2016-08-18 11:05:53]

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:267: *control_ptr =
graph()->NewNode(common()->IfSuccess(), call);
You can't have an IfSuccess without an IfException. You shouldn't need to update
control_ptr here.

[bgeron, 2016-08-18 11:13:20]

On 2016/08/18 11:05:53, titzer wrote:
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:267: *control_ptr =
> graph()->NewNode(common()->IfSuccess(), call);
> You can't have an IfSuccess without an IfException. You shouldn't need to
update
> control_ptr here.

Yes you can. Normally in TurboFan, when there's no try..catch, a no-no-throw
call has an IfSuccess but no IfException. That means that on exception, the call
stack will be walked to find a suitable exception handler.

[bgeron, 2016-08-18 11:13:48]

Description was changed from

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows
==========

to

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows
==========

[titzer, 2016-08-18 11:15:48]

On 2016/08/18 11:13:20, bgeron wrote:
> On 2016/08/18 11:05:53, titzer wrote:
> >
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
> > File src/compiler/wasm-compiler.cc (right):
> > 
> >
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
> > src/compiler/wasm-compiler.cc:267: *control_ptr =
> > graph()->NewNode(common()->IfSuccess(), call);
> > You can't have an IfSuccess without an IfException. You shouldn't need to
> update
> > control_ptr here.
> 
> Yes you can. Normally in TurboFan, when there's no try..catch, a no-no-throw
> call has an IfSuccess but no IfException. That means that on exception, the
call
> stack will be walked to find a suitable exception handler.

Ok. We don't need to have either in this case because there aren't handlers in
WASM functions that can catch JS exceptions.

[ahaas, 2016-08-18 12:32:14]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 12:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-18 12:33:30]

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:267: *control_ptr =
graph()->NewNode(common()->IfSuccess(), call);
On 2016/08/18 at 11:05:53, titzer wrote:
> You can't have an IfSuccess without an IfException. You shouldn't need to
update control_ptr here.

I will remove the IfSuccess nodes for now. We will have to add them again if we
want to inline wasm code into js code.

[titzer, 2016-08-18 12:49:03]

On 2016/08/18 12:33:30, ahaas wrote:
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler.cc
> File src/compiler/wasm-compiler.cc (right):
> 
>
https://codereview.chromium.org/2254803002/diff/1/src/compiler/wasm-compiler....
> src/compiler/wasm-compiler.cc:267: *control_ptr =
> graph()->NewNode(common()->IfSuccess(), call);
> On 2016/08/18 at 11:05:53, titzer wrote:
> > You can't have an IfSuccess without an IfException. You shouldn't need to
> update control_ptr here.
> 
> I will remove the IfSuccess nodes for now. We will have to add them again if
we
> want to inline wasm code into js code.

For the record: Andreas and I discussed this offline and we will need to add
IfSuccess projections to calls later for precise trap locations.

[commit-bot: I haz the power, 2016-08-18 13:48:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 13:48:36]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-08-18 14:26:22]

lgtm

[ahaas, 2016-08-18 14:26:35]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-08-18 14:26:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 14:33:00]

Description was changed from

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows
==========

to

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows
==========

[commit-bot: I haz the power, 2016-08-18 14:33:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 14:33:15]

Description was changed from

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows
==========

to

==========
[wasm] Throw a type error if an I64 is exported to JS.

As required by the spec, ToJS now throws a TypeError fit I64 values
instead of truncating the I64 value to I32. To throw a TypeError I
introduced a new runtime function because the existing
Runtime::kThrowWasmError does not throw a TypeError. Since we have calls
to two runtime functions now, and an additional one is needed for stack
checks, I extracted the call to runtime functions into a helper function.

R=titzer@chromium.org

TEST=mjsunit/wasm/ffi-error.js:I64InSignatureThrows

Committed: https://crrev.com/92b7c728e20e7a7f1ef452322c7295bbaa421704
Cr-Commit-Position: refs/heads/master@{#38718}
==========

[commit-bot: I haz the power, 2016-08-18 14:33:16]

Patchset 2 (id:??) landed as
https://crrev.com/92b7c728e20e7a7f1ef452322c7295bbaa421704
Cr-Commit-Position: refs/heads/master@{#38718}