[SystemInfo API] Implement storage.getAvailableCapacity API

[SystemInfo API] Implement storage.getAvailableCapacity API

BUG=252994
TEST=browser_tests --gtest_filter=SystemStorageApiTest.Storage

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229660

[Haojian Wu, 2013-08-08 10:06:54]

Hongbo@, @Greg for api implementation.
Ilya@ for histograms.xml

[Haojian Wu, 2013-08-08 11:19:58]

On 2013/08/08 10:06:54, Haojian Wu wrote:
> Hongbo@, @Greg for api implementation.
> Ilya@ for histograms.xml

This patch is for early review and will be rebased after
onAvailableCapacityChanged Event and "watch" APIs CL gets landed.

[Ilya Sherman, 2013-08-08 23:05:45]

histograms.xml lgtm

[Hongbo Min, 2013-08-16 05:36:51]

Haojian, you might need to rebase this CL.

[Haojian Wu, 2013-08-16 09:17:16]

On 2013/08/16 05:36:51, Hongbo Min wrote:
> Haojian, you might need to rebase this CL.

Done.

[Hongbo Min, 2013-08-22 02:36:46]

LGTM. ping gbillock@

[Greg Billock, 2013-10-14 20:32:04]

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: DOMString id;
Can we arrange to pass this in JS and just return the capacity in the callback?

[Haojian Wu, 2013-10-15 00:50:25]

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: DOMString id;
On 2013/10/14 20:32:05, Greg Billock wrote:
> Can we arrange to pass this in JS and just return the capacity in the
callback?

Yes. We can just return the capacity instead of this structure.

But we have discussed with Hongbo in
CL:https://codereview.chromium.org/19053003/(see comments)

I think returning the capacity with corresponding storage device |id| in
callback function is better. Without the |id| field, developers should do extra
work to remember which storage device |id| does the |availableCapcity| belong
to, right?

[Greg Billock, 2013-10-15 15:26:03]

This is about ready, I think. Just some docs clarification.

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: DOMString id;
Sounds good.

On 2013/10/15 00:50:26, Haojian Wu wrote:
> On 2013/10/14 20:32:05, Greg Billock wrote:
> > Can we arrange to pass this in JS and just return the capacity in the
> callback?
> 
> Yes. We can just return the capacity instead of this structure.
> 
> But we have discussed with Hongbo in
> CL:https://codereview.chromium.org/19053003/(see comments)
> 
> I think returning the capacity with corresponding storage device |id| in
> callback function is better. Without the |id| field, developers should do
extra
> work to remember which storage device |id| does the |availableCapcity| belong
> to, right?

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: DOMString id;
Add a comment about this id that it is the same ID from StorageUnitInfo.

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:68: // Get the available
capacity of a specified |id| storage device.
Clarify here about id: "... of a specified storage device. The |id| is the
transient device ID from StorageUnitInfo."

[Haojian Wu, 2013-10-16 04:04:23]

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: DOMString id;
On 2013/10/15 15:26:04, Greg Billock wrote:
> Add a comment about this id that it is the same ID from StorageUnitInfo.

Done.

https://codereview.chromium.org/22548009/diff/14001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:68: // Get the available
capacity of a specified |id| storage device.
On 2013/10/15 15:26:04, Greg Billock wrote:
> Clarify here about id: "... of a specified storage device. The |id| is the
> transient device ID from StorageUnitInfo."

Done.

[Greg Billock, 2013-10-16 16:09:48]

lgtm

[commit-bot: I haz the power, 2013-10-17 13:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/28001

[commit-bot: I haz the power, 2013-10-17 13:39:42]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 660.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
a62b0147125b2803c2ea5e146f136a99d77bb175..414c43f2c39228c71cbb795bb5919f720ff89d06
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -660,6 +660,7 @@ enum HistogramValue {
   SOCKETS_TCP_CLOSE,
   SOCKETS_TCP_GETINFO,
   SOCKETS_TCP_GETSOCKETS,
+  SYSTEM_STORAGE_GETAVAILABLECAPACITY,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-10-17 17:05:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/46001

[commit-bot: I haz the power, 2013-10-17 18:29:19]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Haojian Wu, 2013-10-18 00:30:15]

On 2013/10/17 18:29:19, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

ping kalman@, need your LGTM for chrome/common/extensions/api/* and
chrome/browser/extensions/extension_function_histogram_value.h files.

[not at google - send to devlin, 2013-10-18 00:33:11]

lgtm

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: // The same |id| from the
getAvailableCapacity function parameter |id|.
I can't parse this sentence

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:58: callback
getAvailableCapacityCallback = void (
get -> Get

[Haojian Wu, 2013-10-18 00:47:37]

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:34: // The same |id| from the
getAvailableCapacity function parameter |id|.
On 2013/10/18 00:33:11, kalman wrote:
> I can't parse this sentence

Done.

https://codereview.chromium.org/22548009/diff/46001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:58: callback
getAvailableCapacityCallback = void (
On 2013/10/18 00:33:11, kalman wrote:
> get -> Get

The extension api name should follow this way(the first letter of first word is
lower-case), I think. Also see other functions getInfo ejectDevice, etc.

[not at google - send to devlin, 2013-10-18 00:49:56]

https://codereview.chromium.org/22548009/diff/64001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/64001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:58: callback
getAvailableCapacityCallback = void (
the line of code right above this is StorageInfoCallback not
storageInfoCallback. It's a type, so Get, not get.

[Haojian Wu, 2013-10-18 04:51:41]

https://codereview.chromium.org/22548009/diff/64001/chrome/common/extensions/...
File chrome/common/extensions/api/system_storage.idl (right):

https://codereview.chromium.org/22548009/diff/64001/chrome/common/extensions/...
chrome/common/extensions/api/system_storage.idl:58: callback
getAvailableCapacityCallback = void (
On 2013/10/18 00:49:57, kalman wrote:
> the line of code right above this is StorageInfoCallback not
> storageInfoCallback. It's a type, so Get, not get.

Oh, I see. Thanks for the hint. Done.

[commit-bot: I haz the power, 2013-10-18 05:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/97001

[commit-bot: I haz the power, 2013-10-18 05:08:08]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 663.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
47ae02309a5a2ee00742180d1848dc76a5cba5d5..6aaed1bd215122d6cc042a2c35dfaf6ee69502b7
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -663,6 +663,7 @@ enum HistogramValue {
   NETWORKINGPRIVATE_GETENABLEDNETWORKTYPES,
   NETWORKINGPRIVATE_ENABLENETWORKTYPE,
   NETWORKINGPRIVATE_DISABLENETWORKTYPE,
+  SYSTEM_STORAGE_GETAVAILABLECAPACITY,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-10-18 10:08:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/187001

[commit-bot: I haz the power, 2013-10-18 20:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/187001

[commit-bot: I haz the power, 2013-10-19 07:12:42]

Retried try job too often on win7_aura for step(s) app_list_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-20 01:24:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/22548009/187001

[commit-bot: I haz the power, 2013-10-20 05:25:19]

Change committed as 229660