Issue 22548007: [DevTools] Network: prefetch resource content when "preserveLog" is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22548007: [DevTools] Network: prefetch resource content when "preserveLog" is on. (Closed)

Created:
7 years, 4 months ago by eustas

Modified:
5 years, 8 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[DevTools] Network: prefetch resource content when "preserveLog" is on. This prevents resource content becoming unavailable after navigation. BUG=141129

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	Source/devtools/front_end/network/NetworkLogView.js	View	1 2	4 chunks	+31 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsevik

On 2013/08/07 13:37:56, eustas.ru wrote: Not lgtm, requesting content for all resources on one page ...

7 years, 4 months ago (2013-08-07 14:15:30 UTC) #2

eustas

6 years, 5 months ago (2014-07-02 05:02:41 UTC) #3

On 2013/08/07 14:15:30, vsevik wrote:
> On 2013/08/07 13:37:56, eustas.ru wrote:
> 
> Not lgtm, requesting content for all resources on one page is an overkill and
> will regress performance.

Actually we already request content for most network requests (images).
So, it won't hurt performance much.

Also, this is done only when "preserve log" is on, which is not common case,
and directly shows us that user is highly interested in gathering all the data.

PTAL

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages