Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: tests/language/execute_finally10_test.dart

Issue 22548003: Fix uses of throw/rethrow in tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/language/execute_finally11_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Regression test for dart2js that used to not treat the finally 5 // Regression test for dart2js that used to not treat the finally
6 // block as a successor of a catch block that throws. 6 // block as a successor of a catch block that throws.
7 7
8 import "package:expect/expect.dart"; 8 import "package:expect/expect.dart";
9 9
10 class A { 10 class A {
11 var field; 11 var field;
12 start() {} 12 start() {}
13 stop() { field = 42; } 13 stop() { field = 42; }
14 } 14 }
15 15
16 class B { 16 class B {
17 var totalCompileTime = new A(); 17 var totalCompileTime = new A();
18 var runCompiler = new Object(); 18 var runCompiler = new Object();
19 19
20 run() { 20 run() {
21 totalCompileTime.start(); 21 totalCompileTime.start();
22 try { 22 try {
23 throw 'foo'; 23 throw 'foo';
24 } catch (exception) { 24 } catch (exception) {
25 // Use [runCompiler] twice to ensure it will have a local 25 // Use [runCompiler] twice to ensure it will have a local
26 // variable. 26 // variable.
27 runCompiler.toString(); 27 runCompiler.toString();
28 runCompiler.toString(); 28 runCompiler.toString();
29 throw; 29 rethrow;
30 } finally { 30 } finally {
31 totalCompileTime.stop(); 31 totalCompileTime.stop();
32 } 32 }
33 } 33 }
34 } 34 }
35 35
36 main() { 36 main() {
37 var b = new B(); 37 var b = new B();
38 try { 38 try {
39 b.run(); 39 b.run();
40 throw 'Expected exception'; 40 throw 'Expected exception';
41 } catch (exception) { 41 } catch (exception) {
42 // Expected exception. 42 // Expected exception.
43 } 43 }
44 44
45 Expect.equals(42, b.totalCompileTime.field); 45 Expect.equals(42, b.totalCompileTime.field);
46 } 46 }
OLDNEW
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/language/execute_finally11_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698