Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Side by Side Diff: chrome/browser/ui/android/infobars/grouped_permission_infobar.cc

Issue 2254763002: Enable the optional permission prompt persistence toggle on grouped infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobardelegate-clean
Patch Set: DCHECK -> CHECK Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/infobars/grouped_permission_infobar.h" 5 #include "chrome/browser/ui/android/infobars/grouped_permission_infobar.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "chrome/browser/android/resource_mapper.h" 10 #include "chrome/browser/android/resource_mapper.h"
(...skipping 16 matching lines...) Expand all
27 const base::android::JavaParamRef<jobject>& obj, 27 const base::android::JavaParamRef<jobject>& obj,
28 const base::android::JavaParamRef<jbooleanArray>& permissions) { 28 const base::android::JavaParamRef<jbooleanArray>& permissions) {
29 29
30 for (int i = 0; i < GetDelegate()->GetPermissionCount(); i++) { 30 for (int i = 0; i < GetDelegate()->GetPermissionCount(); i++) {
31 jboolean value; 31 jboolean value;
32 env->GetBooleanArrayRegion(permissions.obj(), i, 1, &value); 32 env->GetBooleanArrayRegion(permissions.obj(), i, 1, &value);
33 GetDelegate()->ToggleAccept(i, value); 33 GetDelegate()->ToggleAccept(i, value);
34 } 34 }
35 } 35 }
36 36
37 void GroupedPermissionInfoBar::ProcessButton(int action) {
38 // Check if the delegate asked us to display a persistence toggle. If so,
39 // inform it of the toggle state.
40 GroupedPermissionInfoBarDelegate* delegate = GetDelegate();
41 if (delegate->ShouldShowPersistenceToggle()) {
42 delegate->set_persist(Java_GroupedPermissionInfoBar_isPersistSwitchOn(
43 base::android::AttachCurrentThread(), GetJavaInfoBar()));
44 }
45
46 ConfirmInfoBar::ProcessButton(action);
47 }
48
37 base::android::ScopedJavaLocalRef<jobject> 49 base::android::ScopedJavaLocalRef<jobject>
38 GroupedPermissionInfoBar::CreateRenderInfoBar(JNIEnv* env) { 50 GroupedPermissionInfoBar::CreateRenderInfoBar(JNIEnv* env) {
39 GroupedPermissionInfoBarDelegate* delegate = GetDelegate(); 51 GroupedPermissionInfoBarDelegate* delegate = GetDelegate();
40 52
41 base::android::ScopedJavaLocalRef<jstring> message_text = 53 base::android::ScopedJavaLocalRef<jstring> message_text =
42 base::android::ConvertUTF16ToJavaString( 54 base::android::ConvertUTF16ToJavaString(
43 env, delegate->GetMessageText()); 55 env, delegate->GetMessageText());
44 base::android::ScopedJavaLocalRef<jstring> ok_button_text = 56 base::android::ScopedJavaLocalRef<jstring> ok_button_text =
45 base::android::ConvertUTF16ToJavaString( 57 base::android::ConvertUTF16ToJavaString(
46 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK)); 58 env, GetTextFor(ConfirmInfoBarDelegate::BUTTON_OK));
(...skipping 10 matching lines...) Expand all
57 permission_icons.push_back( 69 permission_icons.push_back(
58 ResourceMapper::MapFromChromiumId(delegate->GetIconIdForPermission(i))); 70 ResourceMapper::MapFromChromiumId(delegate->GetIconIdForPermission(i)));
59 content_settings_types.push_back(delegate->GetContentSettingType(i)); 71 content_settings_types.push_back(delegate->GetContentSettingType(i));
60 } 72 }
61 73
62 return Java_GroupedPermissionInfoBar_create( 74 return Java_GroupedPermissionInfoBar_create(
63 env, message_text, ok_button_text, cancel_button_text, 75 env, message_text, ok_button_text, cancel_button_text,
64 base::android::ToJavaIntArray(env, permission_icons), 76 base::android::ToJavaIntArray(env, permission_icons),
65 base::android::ToJavaArrayOfStrings(env, permission_strings), 77 base::android::ToJavaArrayOfStrings(env, permission_strings),
66 GetWindowAndroid(), 78 GetWindowAndroid(),
67 base::android::ToJavaIntArray(env, content_settings_types)); 79 base::android::ToJavaIntArray(env, content_settings_types),
80 delegate->ShouldShowPersistenceToggle());
68 } 81 }
69 82
70 void GroupedPermissionInfoBar::SetJavaInfoBar( 83 void GroupedPermissionInfoBar::SetJavaInfoBar(
71 const base::android::JavaRef<jobject>& java_info_bar) { 84 const base::android::JavaRef<jobject>& java_info_bar) {
72 InfoBarAndroid::SetJavaInfoBar(java_info_bar); 85 InfoBarAndroid::SetJavaInfoBar(java_info_bar);
73 JNIEnv* env = base::android::AttachCurrentThread(); 86 JNIEnv* env = base::android::AttachCurrentThread();
74 Java_GroupedPermissionInfoBar_setNativePtr(env, java_info_bar, 87 Java_GroupedPermissionInfoBar_setNativePtr(env, java_info_bar,
75 reinterpret_cast<intptr_t>(this)); 88 reinterpret_cast<intptr_t>(this));
76 } 89 }
77 90
78 GroupedPermissionInfoBarDelegate* GroupedPermissionInfoBar::GetDelegate() { 91 GroupedPermissionInfoBarDelegate* GroupedPermissionInfoBar::GetDelegate() {
79 return static_cast<GroupedPermissionInfoBarDelegate*>(delegate()); 92 return static_cast<GroupedPermissionInfoBarDelegate*>(delegate());
80 } 93 }
81 94
82 std::unique_ptr<infobars::InfoBar> 95 std::unique_ptr<infobars::InfoBar>
83 GroupedPermissionInfoBarDelegate::CreateInfoBar( 96 GroupedPermissionInfoBarDelegate::CreateInfoBar(
84 infobars::InfoBarManager* infobar_manager, 97 infobars::InfoBarManager* infobar_manager,
85 std::unique_ptr<GroupedPermissionInfoBarDelegate> delegate) { 98 std::unique_ptr<GroupedPermissionInfoBarDelegate> delegate) {
86 return std::unique_ptr<infobars::InfoBar>( 99 return std::unique_ptr<infobars::InfoBar>(
87 new GroupedPermissionInfoBar(std::move(delegate))); 100 new GroupedPermissionInfoBar(std::move(delegate)));
88 } 101 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/infobars/grouped_permission_infobar.h ('k') | content/test/data/android/media_permissions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698