Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2254753002: Unit test:Make sure WebRtcAudioRenderer always plays sink after starting it. (Closed)

Created:
4 years, 4 months ago by o1ka
Modified:
4 years, 4 months ago
Reviewers:
Henrik Grunell, miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure WebRtcAudioRenderer always plays sink after starting it. BUG=633930 Committed: https://crrev.com/f82d25be084cd948d6f707ef87df8f61afcbf15f Cr-Commit-Position: refs/heads/master@{#413368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
o1ka
PTAL
4 years, 4 months ago (2016-08-17 10:20:32 UTC) #2
Henrik Grunell
lgtm The title and description should reflect that this is a unit test update, as ...
4 years, 4 months ago (2016-08-17 10:30:07 UTC) #3
o1ka
miu@chromium.org: Please RS as an owner
4 years, 4 months ago (2016-08-17 10:32:33 UTC) #6
miu
lgtm
4 years, 4 months ago (2016-08-21 04:37:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254753002/1
4 years, 4 months ago (2016-08-21 04:38:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 05:22:22 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 05:23:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f82d25be084cd948d6f707ef87df8f61afcbf15f
Cr-Commit-Position: refs/heads/master@{#413368}

Powered by Google App Engine
This is Rietveld 408576698