Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2254733008: include extra_cflags* in the step description (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gn/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 4 months ago (2016-08-19 00:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254733008/1
4 years, 4 months ago (2016-08-19 00:48:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254733008/1
4 years, 4 months ago (2016-08-19 11:23:00 UTC) #9
rmistry
I was trying to figure out why this did not land yet after being in ...
4 years, 4 months ago (2016-08-19 11:26:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/15d71ff5376e2051129f88898bebb29544d03c07
4 years, 4 months ago (2016-08-19 11:27:37 UTC) #12
rmistry
On 2016/08/19 11:27:37, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 4 months ago (2016-08-19 11:33:33 UTC) #13
jcgregorio
4 years, 4 months ago (2016-08-19 16:05:46 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698