chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css - Issue 2254733004: ChromeOS: Update styles of material design OOBE.

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css

Issue 2254733004: ChromeOS: Update styles of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing files. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/oobe_eula.html ('K') | « chrome/browser/resources/chromeos/login/oobe_eula.html ('k') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html » ('j') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2016 The Chromium Authors. All rights reserved.

	2 Use of this source code is governed by a BSD-style license that can be
	michaelpg 2016/08/18 19:40:59 asterisks asterisks
	3 found in the LICENSE file. */

	4

	5 :host {

	6 --paper-font-subhead_-_font-family: Roboto, sans-serif;
	michaelpg 2016/08/18 19:40:59 These names are implementation details of Polymer' These names are implementation details of Polymer's mixin shim; do not use them. Whatever you're trying to style that uses @apply(--paper-font-subhead), see if you can style that directly or if it provides variables or mixins to override these styles. If you really have to, override the mixin itself, without throwing away --paper-font-common-base: https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903... Alexander Alekseev 2016/08/19 06:00:06 This is needed to style <input> element inside <pa Show quoted text On 2016/08/18 19:40:59, michaelpg wrote: > These names are implementation details of Polymer's mixin shim; do not use them. > > Whatever you're trying to style that uses @apply(--paper-font-subhead), see if > you can style that directly or if it provides variables or mixins to override > these styles. > > If you really have to, override the mixin itself, without throwing away > --paper-font-common-base: > > https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903... This is needed to style <input> element inside <paper-dropdown-menu>. And I didn't find another way to style it. I couldn't get overridden mixin to work. michaelpg 2016/08/19 06:10:49 I'm sorry, but this is not a good way of doing it. Show quoted text On 2016/08/19 06:00:06, Alexander Alekseev wrote: > On 2016/08/18 19:40:59, michaelpg wrote: > > These names are implementation details of Polymer's mixin shim; do not use > them. > > > > Whatever you're trying to style that uses @apply(--paper-font-subhead), see if > > you can style that directly or if it provides variables or mixins to override > > these styles. > > > > If you really have to, override the mixin itself, without throwing away > > --paper-font-common-base: > > > > > https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903... > > This is needed to style <input> element inside <paper-dropdown-menu>. And I > didn't find another way to style it. > I couldn't get overridden mixin to work. I'm sorry, but this is not a good way of doing it. Polymer could (and probably will) change this at any time, and whoever is pulling Polymer into Chrome won't know to check that the <input> of a dropdown menu in OOBE is a certain exact font. Again, check the paper-dropdown-menu docs and look for mixins, there are definitely ways to style the input. Alexander Alekseev 2016/08/19 06:25:43 Ok, let's remove this by now (this will result in Show quoted text On 2016/08/19 06:10:49, michaelpg wrote: > On 2016/08/19 06:00:06, Alexander Alekseev wrote: > > On 2016/08/18 19:40:59, michaelpg wrote: > > > These names are implementation details of Polymer's mixin shim; do not use > > them. > > > > > > Whatever you're trying to style that uses @apply(--paper-font-subhead), see > if > > > you can style that directly or if it provides variables or mixins to > override > > > these styles. > > > > > > If you really have to, override the mixin itself, without throwing away > > > --paper-font-common-base: > > > > > > > > > https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903... > > > > This is needed to style <input> element inside <paper-dropdown-menu>. And I > > didn't find another way to style it. > > I couldn't get overridden mixin to work. > > I'm sorry, but this is not a good way of doing it. Polymer could (and probably > will) change this at any time, and whoever is pulling Polymer into Chrome won't > know to check that the <input> of a dropdown menu in OOBE is a certain exact > font. > > Again, check the paper-dropdown-menu docs and look for mixins, there are > definitely ways to style the input. Ok, let's remove this by now (this will result in incorrect font height, but I will return to this later).
	7 --paper-font-subhead_-_font-size: 13px;

	8 --paper-font-subhead_-_font-weight: normal;

	9 }

	10

	11 .selected-icon {

	12 --iron-icon-height: 16px;

	13 --iron-icon-width: 16px;

	14 color: var(--google-blue-500);

	15 padding-left: 8px;

	16 }

	17

	18 paper-item:not([hr]) {
	michaelpg 2016/08/18 19:40:59 :not([hr]) probably isn't necessary :not([hr]) probably isn't necessary Alexander Alekseev 2016/08/19 06:00:06 Done. Show quoted text On 2016/08/18 19:40:59, michaelpg wrote: > :not([hr]) probably isn't necessary Done. Alexander Alekseev 2016/08/19 06:00:06 Done. Show quoted text On 2016/08/18 19:40:59, michaelpg wrote: > :not([hr]) probably isn't necessary Done.
	19 min-height: 32px;

	20 }

	21

	22 paper-item[hr] {

	23 min-height: 10px;

	24 }

	25

	26 .option-name {

	27 color: rgba(0, 0, 0, 0.87);

	28 font-family: Roboto, sans-serif;

	29 font-size: 13px;

	30 font-variant: normal;

	31 }

	32

	33 .hr {

	34 border-top-color: rgba(0, 0, 0, 0.14);
	michaelpg 2016/08/18 19:40:59 use "border" shorthand use "border" shorthand Alexander Alekseev 2016/08/19 06:00:06 Done. Show quoted text On 2016/08/18 19:40:59, michaelpg wrote: > use "border" shorthand Done.
	35 border-top-style: solid;

	36 border-top-width: 1px;

	37 width: 100%;

	38 }

OLD	NEW