chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css - Issue 2254733004: ChromeOS: Update styles of material design OOBE.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css

Issue 2254733004: ChromeOS: Update styles of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing files. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/oobe_dialog.css ('K') | « chrome/browser/resources/chromeos/login/oobe_dialog.html ('k') | chrome/browser/resources/chromeos/login/oobe_dialog_host.css » ('j') | chrome/browser/resources/chromeos/login/oobe_eula.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2016 The Chromium Authors. All rights reserved.
	michaelpg 2016/08/18 19:40:58 I don't understand the naming; how are these "argu I don't understand the naming; how are these "arguments"? Alexander Alekseev 2016/08/19 06:00:05 Let it be "parameters". Show quoted text On 2016/08/18 19:40:58, michaelpg wrote: > I don't understand the naming; how are these "arguments"? Let it be "parameters".
	2 Use of this source code is governed by a BSD-style license that can be
	michaelpg 2016/08/18 19:40:58 asterisks as other files asterisks as other files Alexander Alekseev 2016/08/19 06:00:05 Done. Show quoted text On 2016/08/18 19:40:58, michaelpg wrote: > asterisks as other files Done.
	3 found in the LICENSE file. */

	4

	5 iron-icon.oobe-icon {

	6 --iron-icon-height: 32px;

	7 --iron-icon-width: 32px;

	8 color: var(--google-blue-500);

	9 }

	10

	11 oobe-dialog .header {

	12 color: rgba(0, 0, 0, 0.87);

	13 font-family: Roboto, sans-serif;
	michaelpg 2016/08/18 19:40:58 Hmm, you specify the same font-family in many plac Hmm, you specify the same font-family in many places. Should the whole app be Roboto? It should inherit by default. Alexander Alekseev 2016/08/19 06:00:06 In OOBE it is very difficult to guess what a style Show quoted text On 2016/08/18 19:40:58, michaelpg wrote: > Hmm, you specify the same font-family in many places. Should the whole app be > Roboto? It should inherit by default. In OOBE it is very difficult to guess what a style is going to affect. So I think it is much safer to specify styles only for the elements that need it.
	14 font-variant: normal;
	michaelpg 2016/08/18 19:40:58 What is this for? What is this for? Alexander Alekseev 2016/08/19 06:00:05 Done. Show quoted text On 2016/08/18 19:40:58, michaelpg wrote: > What is this for? Done.
	15 }

	16

	17 oobe-dialog h1.title {

	18 color: rgba(0, 0, 0, 0.87);

	19 font-size: 28px;

	20 font-weight: normal;
	michaelpg 2016/08/18 19:40:58 nit: inherit, if you want to use the same font-wei nit: inherit, if you want to use the same font-weight as the rest of the app Alexander Alekseev 2016/08/19 06:00:06 Done. Show quoted text On 2016/08/18 19:40:58, michaelpg wrote: > nit: inherit, if you want to use the same font-weight as the rest of the app Done.
	21 margin-bottom: 0;

	22 margin-top: 36px; /* = 64 - font height*/

	23 }

	24

	25 oobe-dialog .subtitle {

	26 color: rgba(0, 0, 0, 0.87);

	27 font-size: 13px;

	28 margin-bottom: 0;

	29 margin-top: 27px; /* = 40 - line-height */

	30 }

	31

	32 oobe-dialog .footer {

	33 height: 100%;

	34 }

	35

	36 oobe-dialog .bottom-buttons {

	37 width: 100%

	38 }

OLD	NEW