ChromeOS: Update styles of material design OOBE.

ChromeOS: Update styles of material design OOBE.

This CL fixes styles of oobe-dialog based screens.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a96714548fcf54eecb86d95f4c92561262e07c6d
Cr-Commit-Position: refs/heads/master@{#413078}

[Alexander Alekseev, 2016-08-18 06:49:29]

Description was changed from

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of oobe-dialog based screens.

BUG=604119
TEST=none
==========

to

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of oobe-dialog based screens.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2016-08-18 06:49:57]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2016-08-18 06:49:58]

Please review.

[Alexander Alekseev, 2016-08-18 06:50:07]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 06:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 06:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 06:59:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-08-18 07:28:23]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 07:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:20:28]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-18 19:40:59]

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_a11y_option.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.css:12: width: inherit;
width: inherit is unusual. Do you actually need two containing divs, or can you
just style :host as needed?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.css:24: font-weight:
normal;
what are these font-weight values overriding?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_a11y_option.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.html:8: <div
id="element-box" class="layout horizontal">
elementBox for consistency with other IDs

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:2: Use of this source
code is governed by a BSD-style license that can be
asterisks as other files

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:6: padding-left: 64px;
nit: use shorthand
    padding: 64px 64px 64px 0;

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:16: padding-left: 64px;
same: shorthand

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:24: min-height: 80px;
can "min-height" just be "height" if you want the height to be 80px?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:1: /*
Copyright 2016 The Chromium Authors. All rights reserved.
I don't understand the naming; how are these "arguments"?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:2: Use of this
source code is governed by a BSD-style license that can be
asterisks as other files

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:13:
font-family: Roboto, sans-serif;
Hmm, you specify the same font-family in many places. Should the whole app be
Roboto? It should inherit by default.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:14:
font-variant: normal;
What is this for?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:20:
font-weight: normal;
nit: inherit, if you want to use the same font-weight as the rest of the app

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.css:9: 
rm trailing line

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.html:47: <div
class="flex"><!-- spacer to align button to the right --></div>
would bottom-buttons {justify-content: flex-end} work instead of a spacer? (is
that what the end-justified class does?)

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:2: Use of this
source code is governed by a BSD-style license that can be
asterisks

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6:
--paper-font-subhead_-_font-family: Roboto, sans-serif;
These names are implementation details of Polymer's mixin shim; do not use them.

Whatever you're trying to style that uses @apply(--paper-font-subhead), see if
you can style that directly or if it provides variables or mixins to override
these styles.

If you really have to, override the mixin itself, without throwing away
--paper-font-common-base:

https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903...

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:18:
paper-item:not([hr]) {
:not([hr]) probably isn't necessary

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:34:
border-top-color: rgba(0, 0, 0, 0.14);
use "border" shorthand

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html:34:
hr$="[[item.optionGroupName]]">
if these are the same, can you just style on [disabled] instead of adding a hr
attribute?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.css:24: padding-left: 20px;
padding: 0 20px;

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.css:45: border-bottom: 1px
solid rgba(0,0,0,0.14);
nit: spaces after ,

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:22: <link
rel="stylesheet" href="oobe_dialog_host.css" is="custom-style">
AFAIK is="custom-style" has no meaning for <link rel="stylesheet">.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:84: <div
class="flex"><!-- spacer to align button to the right --></div>
same: use end-justified on .bottom-buttons instead?

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:97:
i18n-content="accessibilitySectionHint">
unwrap

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:148: <div
class="flex"><!-- spacer to align button to the right --></div>
(same. throughout)

[Alexander Alekseev, 2016-08-19 06:00:06]

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_a11y_option.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.css:12: width: inherit;
On 2016/08/18 19:40:58, michaelpg wrote:
> width: inherit is unusual. Do you actually need two containing divs, or can
you
> just style :host as needed?

element box is needed for "layout horizontal".

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.css:24: font-weight:
normal;
On 2016/08/18 19:40:58, michaelpg wrote:
> what are these font-weight values overriding?


The idea was to exactly follow the design: if font is specified for the element,
let's set it for this element. So that it would stay the same whatever changes
above are made.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_a11y_option.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_a11y_option.html:8: <div
id="element-box" class="layout horizontal">
On 2016/08/18 19:40:58, michaelpg wrote:
> elementBox for consistency with other IDs

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:2: Use of this source
code is governed by a BSD-style license that can be
On 2016/08/18 19:40:58, michaelpg wrote:
> asterisks as other files

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:6: padding-left: 64px;
On 2016/08/18 19:40:58, michaelpg wrote:
> nit: use shorthand
>     padding: 64px 64px 64px 0;

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:16: padding-left: 64px;
On 2016/08/18 19:40:58, michaelpg wrote:
> same: shorthand

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog.css:24: min-height: 80px;
On 2016/08/18 19:40:58, michaelpg wrote:
> can "min-height" just be "height" if you want the height to be 80px?

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:1: /*
Copyright 2016 The Chromium Authors. All rights reserved.
On 2016/08/18 19:40:58, michaelpg wrote:
> I don't understand the naming; how are these "arguments"?

Let it be "parameters".

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:2: Use of this
source code is governed by a BSD-style license that can be
On 2016/08/18 19:40:58, michaelpg wrote:
> asterisks as other files

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:13:
font-family: Roboto, sans-serif;
On 2016/08/18 19:40:58, michaelpg wrote:
> Hmm, you specify the same font-family in many places. Should the whole app be
> Roboto? It should inherit by default.

In OOBE it is very difficult to guess what a style is going to affect. So I
think it is much safer to specify styles only for the elements that  need it.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:14:
font-variant: normal;
On 2016/08/18 19:40:58, michaelpg wrote:
> What is this for?

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_dialog_arguments.css:20:
font-weight: normal;
On 2016/08/18 19:40:58, michaelpg wrote:
> nit: inherit, if you want to use the same font-weight as the rest of the app

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.css:9: 
On 2016/08/18 19:40:59, michaelpg wrote:
> rm trailing line

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.html:47: <div
class="flex"><!-- spacer to align button to the right --></div>
On 2016/08/18 19:40:59, michaelpg wrote:
> would bottom-buttons {justify-content: flex-end} work instead of a spacer? (is
> that what the end-justified class does?)

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6:
--paper-font-subhead_-_font-family: Roboto, sans-serif;
On 2016/08/18 19:40:59, michaelpg wrote:
> These names are implementation details of Polymer's mixin shim; do not use
them.
> 
> Whatever you're trying to style that uses @apply(--paper-font-subhead), see if
> you can style that directly or if it provides variables or mixins to override
> these styles.
> 
> If you really have to, override the mixin itself, without throwing away
> --paper-font-common-base:
> 
>
https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903...

This is needed to style <input> element inside <paper-dropdown-menu>. And I
didn't find another way to style it.
I couldn't get overridden mixin to work.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:18:
paper-item:not([hr]) {
On 2016/08/18 19:40:59, michaelpg wrote:
> :not([hr]) probably isn't necessary

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:18:
paper-item:not([hr]) {
On 2016/08/18 19:40:59, michaelpg wrote:
> :not([hr]) probably isn't necessary

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:34:
border-top-color: rgba(0, 0, 0, 0.14);
On 2016/08/18 19:40:59, michaelpg wrote:
> use "border" shorthand

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html:34:
hr$="[[item.optionGroupName]]">
On 2016/08/18 19:40:59, michaelpg wrote:
> if these are the same, can you just style on [disabled] instead of adding a hr
> attribute?

The problem is that "disabled" has implied meaning (that matches exactly what it
says ;) ), so that someone who would need to add disabled regular items to the
list, will never know that "disabled" is also used as a flag to display <hr>
entry. So I'd vote for using different properties for different purposes.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.css:24: padding-left: 20px;
On 2016/08/18 19:40:59, michaelpg wrote:
> padding: 0 20px;

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.css:45: border-bottom: 1px
solid rgba(0,0,0,0.14);
On 2016/08/18 19:40:59, michaelpg wrote:
> nit: spaces after ,

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:22: <link
rel="stylesheet" href="oobe_dialog_host.css" is="custom-style">
On 2016/08/18 19:40:59, michaelpg wrote:
> AFAIK is="custom-style" has no meaning for <link rel="stylesheet">.

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:84: <div
class="flex"><!-- spacer to align button to the right --></div>
On 2016/08/18 19:40:59, michaelpg wrote:
> same: use end-justified on .bottom-buttons instead?

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:97:
i18n-content="accessibilitySectionHint">
On 2016/08/18 19:40:59, michaelpg wrote:
> unwrap

Done.

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:148: <div
class="flex"><!-- spacer to align button to the right --></div>
On 2016/08/18 19:40:59, michaelpg wrote:
> (same. throughout)

Done.

[Alexander Alekseev, 2016-08-19 06:00:13]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 06:00:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-19 06:10:49]

thanks, looks much better -- just try again on the mixin

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6:
--paper-font-subhead_-_font-family: Roboto, sans-serif;
On 2016/08/19 06:00:06, Alexander Alekseev wrote:
> On 2016/08/18 19:40:59, michaelpg wrote:
> > These names are implementation details of Polymer's mixin shim; do not use
> them.
> > 
> > Whatever you're trying to style that uses @apply(--paper-font-subhead), see
if
> > you can style that directly or if it provides variables or mixins to
override
> > these styles.
> > 
> > If you really have to, override the mixin itself, without throwing away
> > --paper-font-common-base:
> > 
> >
>
https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903...
> 
> This is needed to style <input> element inside <paper-dropdown-menu>. And I
> didn't find another way to style it.
> I couldn't get overridden mixin to work.

I'm sorry, but this is not a good way of doing it. Polymer could (and probably
will) change this at any time, and whoever is pulling Polymer into Chrome won't
know to check that the <input> of a dropdown menu in OOBE is a certain exact
font.

Again, check the paper-dropdown-menu docs and look for mixins, there are
definitely ways to style the input.

https://codereview.chromium.org/2254733004/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2254733004/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.html:47: <div
class="flex"><!-- spacer to align button to the right --></div>
still think this can be done without a spacer element

[Alexander Alekseev, 2016-08-19 06:25:43]

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2254733004/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6:
--paper-font-subhead_-_font-family: Roboto, sans-serif;
On 2016/08/19 06:10:49, michaelpg wrote:
> On 2016/08/19 06:00:06, Alexander Alekseev wrote:
> > On 2016/08/18 19:40:59, michaelpg wrote:
> > > These names are implementation details of Polymer's mixin shim; do not use
> > them.
> > > 
> > > Whatever you're trying to style that uses @apply(--paper-font-subhead),
see
> if
> > > you can style that directly or if it provides variables or mixins to
> override
> > > these styles.
> > > 
> > > If you really have to, override the mixin itself, without throwing away
> > > --paper-font-common-base:
> > > 
> > >
> >
>
https://github.com/PolymerElements/paper-styles/blob/5fabbe6799996e1c1f3c4903...
> > 
> > This is needed to style <input> element inside <paper-dropdown-menu>. And I
> > didn't find another way to style it.
> > I couldn't get overridden mixin to work.
> 
> I'm sorry, but this is not a good way of doing it. Polymer could (and probably
> will) change this at any time, and whoever is pulling Polymer into Chrome
won't
> know to check that the <input> of a dropdown menu in OOBE is a certain exact
> font.
> 
> Again, check the paper-dropdown-menu docs and look for mixins, there are
> definitely ways to style the input.

Ok, let's remove this by now (this will result in incorrect font height, but I
will return to this later).

https://codereview.chromium.org/2254733004/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_eula.html (right):

https://codereview.chromium.org/2254733004/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_eula.html:47: <div
class="flex"><!-- spacer to align button to the right --></div>
On 2016/08/19 06:10:49, michaelpg wrote:
> still think this can be done without a spacer element

Done.

(I missed this)

[michaelpg, 2016-08-19 06:27:48]

lgtm

[Alexander Alekseev, 2016-08-19 06:29:19]

Thank you!

[Alexander Alekseev, 2016-08-19 06:29:24]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-08-19 06:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 07:45:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-19 07:47:35]

Description was changed from

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of oobe-dialog based screens.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of oobe-dialog based screens.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a96714548fcf54eecb86d95f4c92561262e07c6d
Cr-Commit-Position: refs/heads/master@{#413078}
==========

[commit-bot: I haz the power, 2016-08-19 07:47:36]

Patchset 6 (id:??) landed as
https://crrev.com/a96714548fcf54eecb86d95f4c92561262e07c6d
Cr-Commit-Position: refs/heads/master@{#413078}