Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 2254713002: Revert of Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, agable, ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (patchset #2 id:20001 of https://codereview.chromium.org/2250053005/ ) Reason for revert: Still breaks internal bots, e.g. https://goto.google.com/ggkgw Original issue's description: > Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. > > This is a re-land of https://codereview.chromium.org/2103073002/ - it should > work now we've added the necessary dependencies to slave.DEPS and master.DEPS. > > BUG=620610 > TBR=sergeyberezin > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57e6bac9ebc8193f42036b TBR=sergeyberezin@chromium.org,dsansome@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620610 Committed: https://chromium.googlesource.com/chromium/tools/build/+/6879eab59f9c4fd8ca4b6b55721b09dd53858306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -101 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M masters/buildbot.tac View 1 chunk +1 line, -24 lines 0 comments Download
M scripts/master/master_utils.py View 2 chunks +1 line, -3 lines 0 comments Download
D scripts/master/monitoring_status_receiver.py View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/baseweb.py View 3 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
Created Revert of Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.
4 years, 4 months ago (2016-08-17 08:26:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254713002/1
4 years, 4 months ago (2016-08-17 08:26:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/6879eab59f9c4fd8ca4b6b55721b09dd53858306
4 years, 4 months ago (2016-08-17 08:26:22 UTC) #5
Sergey Berezin
4 years, 4 months ago (2016-08-17 16:36:15 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698