third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html - Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe… Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/url_request_http_job.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html » ('j') | third_party/WebKit/Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

index 9b7c91645316a523a98e9f0ff0af6c65e2775fd1..2e0bd70cbc1257933497566339852f45c5a2e957 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

@@ -27,8 +27,6 @@ promise_test(t => {

'TypeError.')

assert_equals(result.credentials, 'include', 'request.credentials');

assert_equals(result.redirect, 'manual', 'request.redirect');

- assert_equals(result.headers['user-agent'], navigator.userAgent,

- 'User-Agent header');

assert_equals(result.append_header_error, 'TypeError',

'Appending a new header to the request must throw a ' +

'TypeError.')