third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp - Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp

Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe… Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed Android test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/fetch/window/useragent-header.html ('K') | « third_party/WebKit/Source/platform/network/ResourceRequest.cpp ('k') | third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp

diff --git a/third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp b/third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp

index 88e7c05d9c830fab40f3051adc65aaacd472af41..6299f44b20294c254c854c7fa0eef302c4a74c97 100644

--- a/third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp

+++ b/third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp

@@ -33,6 +33,7 @@ TEST(ResourceRequestTest, CrossThreadResourceRequestData)

original.setHTTPMethod(HTTPNames::GET);

original.setHTTPHeaderField(AtomicString("Foo"), AtomicString("Bar"));

original.setHTTPHeaderField(AtomicString("Piyo"), AtomicString("Fuga"));

+ original.setDefaultHTTPUserAgent("Human");

original.setPriority(ResourceLoadPriorityLow, 20);

RefPtr<EncodedFormData> originalBody(EncodedFormData::create("Test Body"));

@@ -59,6 +60,7 @@ TEST(ResourceRequestTest, CrossThreadResourceRequestData)

EXPECT_STREQ("GET", original.httpMethod().utf8().data());

EXPECT_STREQ("Bar", original.httpHeaderFields().get("Foo").utf8().data());

EXPECT_STREQ("Fuga", original.httpHeaderFields().get("Piyo").utf8().data());

+ EXPECT_STREQ("Human", original.defaultHTTPUserAgent().utf8().data());

EXPECT_EQ(ResourceLoadPriorityLow, original.priority());

EXPECT_STREQ("Test Body", original.httpBody()->flattenToString().utf8().data());

EXPECT_FALSE(original.allowStoredCredentials());

@@ -86,6 +88,7 @@ TEST(ResourceRequestTest, CrossThreadResourceRequestData)

EXPECT_STREQ("www.example.com", copy1.requestorOrigin()->host().utf8().data());

EXPECT_STREQ("GET", copy1.httpMethod().utf8().data());

EXPECT_STREQ("Bar", copy1.httpHeaderFields().get("Foo").utf8().data());

+ EXPECT_STREQ("Human", copy1.defaultHTTPUserAgent().utf8().data());

EXPECT_EQ(ResourceLoadPriorityLow, copy1.priority());

EXPECT_STREQ("Test Body", copy1.httpBody()->flattenToString().utf8().data());

EXPECT_FALSE(copy1.allowStoredCredentials());