third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js - Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe… Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed Android test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/fetch/resources/useragent-header-iframe.html ('K') | « third_party/WebKit/LayoutTests/http/tests/fetch/resources/useragent-header-iframe.html ('k') | third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/useragent-header-via-empty-worker.html » ('j') | third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker-proxied/useragent-header-via-empty-worker.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

index 8ead4552122f1b88a5c7bd99c05aad06219bf1cb..36844f066822c67ac05e3092dc8b3113b193dbcc 100644

--- a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

@@ -21,8 +21,7 @@ test(function() {

assert_true(request.headers instanceof Headers,

'Request.headers should be Headers');

- // 'User-Agent' is a forbidden header.

- assert_equals(size(request.headers), 2,

+ assert_equals(size(request.headers), 3,

'Request.headers size should match');

// Note: detailed behavioral tests for Headers are in another test,

// http/tests/fetch/*/headers.html.