Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js

Issue 2254693002: Delay generation of User-Agent header to URLRequestHttpJob and accept custom User-Agent from XHR/Fe… Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed Android test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js b/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
index 8646486fd68403396158e97d3173ec687fadc970..19d0e1591033256fcf9c666eed4fbfab8b3ac64c 100644
--- a/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js
@@ -102,7 +102,8 @@ var checkJsonpResult = function(expected, url, data) {
var checkJsonpHeader = function(name, value, url, data) {
assert_equals(data.jsonpResult,
'success',
- url + ' jsonpResult must be success');
+ url + ' jsonpResult must be success (header check name:' +
+ name + ')');
assert_equals(data.headers[name],
value,
'Request header check failed url:' + url + ' name:' + name);
@@ -110,7 +111,7 @@ var checkJsonpHeader = function(name, value, url, data) {
var checkJsonpMethod = function(method, url, data) {
assert_equals(data.jsonpResult,
'success',
- url + ' jsonpResult must be success');
+ url + ' jsonpResult must be success (method:' + method + ')');
assert_equals(data.method,
method,
'Method must match url:' + url);
@@ -118,7 +119,8 @@ var checkJsonpMethod = function(method, url, data) {
var checkJsonpAuth = function(username, password, cookie, url, data) {
assert_equals(data.jsonpResult,
'success',
- url + ' jsonpResult must be success');
+ url + ' jsonpResult must be success (username:' + username +
+ ' password:' + password + ' cookie:' + cookie);
assert_equals(data.username,
username,
'Username must match. url: ' + url);

Powered by Google App Engine
This is Rietveld 408576698