DevTools: setting to auto-reveal in navigator

third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 337 matching lines @@
      * @param {!WebInspector.UILocation} uiLocation
      * @param {boolean=} omitFocus
      */
     showUILocation: function(uiLocation, omitFocus)
     {
         this.showUISourceCode(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber, omitFocus);
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
+     * @param {boolean=} skipShow
      */
-    _revealInNavigator: function(uiSourceCode)
+    _revealInNavigator: function(uiSourceCode, skipShow)
     {
         var extensions = self.runtime.extensions(WebInspector.NavigatorView);
         Promise.all(extensions.map(extension => extension.instance())).then(filterNavigators);
 
         /**
          * @param {!Array.<!Object>} objects
          */
         function filterNavigators(objects)
         {
             for (var i = 0; i < objects.length; ++i) {
                 var navigatorView = /** @type {!WebInspector.NavigatorView} */ (objects[i]);
                 if (navigatorView.accept(uiSourceCode)) {
                     navigatorView.revealUISourceCode(uiSourceCode, true);
-                    WebInspector.viewManager.showView(extensions[i].descriptor()["viewId"]);
+                    if (skipShow)

[lushnikov, 2016/08/25 02:00:09]

should it be vice-versa?

[luoe, 2016/08/25 18:19:34]

This check is wrong.  Really, we want to call showView so that clicking on a
snippet will open the 'snippets' tab in the navigator when it's open.  I've
changed it to a boolean passed in that tells the view to skip the reveal
callback.  This prevents the navigator from opening, but still switches tabs
(sources/content scripts/snippets) when it's open.

+                        WebInspector.viewManager.showView(extensions[i].descriptor()["viewId"]);
                 }
             }
         }
     },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     _populateNavigatorMenu: function(contextMenu)
     {
@@ skipping 136 matching lines @@
         return true;
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _editorSelected: function(event)
     {
         var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data);
         this._editorChanged(uiSourceCode);
+        if (this.editorView.mainWidget() && WebInspector.moduleSetting("autoRevealInNavigator").get())
+            this._revealInNavigator(uiSourceCode, true);
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _editorClosed: function(event)
     {
         var wasSelected = /** @type {boolean} */ (event.data.wasSelected);
         if (wasSelected)
             this._editorChanged(null);
@@ skipping 827 matching lines @@
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @return {boolean}
  */
 WebInspector.SourcesPanel.WrapperView.isShowing = function()
 {
     return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.SourcesPanel.WrapperView._instance.isShowing();
 }