DevTools: setting to auto-reveal in navigator

third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 337 matching lines @@
      * @param {!WebInspector.UILocation} uiLocation
      * @param {boolean=} omitFocus
      */
     showUILocation: function(uiLocation, omitFocus)
     {
         this.showUISourceCode(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber, omitFocus);
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
+     * @param {boolean=} skipReveal
      */
-    _revealInNavigator: function(uiSourceCode)
+    _revealInNavigator: function(uiSourceCode, skipReveal)

[lushnikov, 2016/08/26 22:31:09]

this seems to be never used.

[luoe, 2016/08/26 23:14:28]

Yeah, I messed up the if statement on #376

     {
         var extensions = self.runtime.extensions(WebInspector.NavigatorView);
-        Promise.all(extensions.map(extension => extension.instance())).then(filterNavigators);
+        Promise.all(extensions.map(extension => extension.instance())).then(filterNavigators.bind(this));
 
         /**
+         * @this {WebInspector.SourcesPanel}
          * @param {!Array.<!Object>} objects
          */
         function filterNavigators(objects)
         {
             for (var i = 0; i < objects.length; ++i) {
                 var navigatorView = /** @type {!WebInspector.NavigatorView} */ (objects[i]);
+                var viewId = extensions[i].descriptor()["viewId"];
                 if (navigatorView.accept(uiSourceCode)) {
                     navigatorView.revealUISourceCode(uiSourceCode, true);
-                    WebInspector.viewManager.showView(extensions[i].descriptor()["viewId"]);
+                    if (this.editorView.mainWidget())

[lushnikov, 2016/08/26 22:31:09]

isn't it the same as always calling WebInspector.viewManager.showView(viewId) ?

[pfeldman, 2016/08/26 22:36:27]

You should not do WebInspector.viewManager.showView(viewId) until necessary.

[luoe, 2016/08/26 23:14:28]

Right, the condition should say if (skipReveal) {...} else { showView }
showView should only be called if we are handling a context menu event.

[luoe, 2016/08/26 23:14:28]

Sorry, this condition should have been skipReveal, which is only true when the
setting is on && tab is selected.

+                        this._navigatorTabbedLocation.tabbedPane().selectTab(viewId);
+                    else
+                        WebInspector.viewManager.showView(viewId);
                 }
             }
         }
     },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     _populateNavigatorMenu: function(contextMenu)
     {
@@ skipping 136 matching lines @@
         return true;
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _editorSelected: function(event)
     {
         var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data);
         this._editorChanged(uiSourceCode);
+        if (this.editorView.mainWidget() && WebInspector.moduleSetting("autoRevealInNavigator").get())
+            this._revealInNavigator(uiSourceCode, true);
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _editorClosed: function(event)
     {
         var wasSelected = /** @type {boolean} */ (event.data.wasSelected);
         if (wasSelected)
             this._editorChanged(null);
@@ skipping 827 matching lines @@
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @return {boolean}
  */
 WebInspector.SourcesPanel.WrapperView.isShowing = function()
 {
     return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.SourcesPanel.WrapperView._instance.isShowing();
 }