Remove dependency on AudioStub in ConnectionToClient

Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505
Committed: https://crrev.com/cd16e206c2182e96019d58d2fa53f6f9d327e6d4
Cr-Commit-Position: refs/heads/master@{#418002}

[Sergey Ulanov, 2016-08-17 06:58:01]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-08-17 18:17:30]

lgtm

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/audio_sen...
File remoting/protocol/audio_send_stream.h (right):

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/audio_sen...
remoting/protocol/audio_send_stream.h:12: // and sending it to the client.
Since the API makes no reference to AudioSource or any client classes, perhaps
it's named too narrowly. How about just calling it AudioStream?

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/ice_conne...
File remoting/protocol/ice_connection_to_client.cc (right):

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/ice_conne...
remoting/protocol/ice_connection_to_client.cc:38: if (audio_config.codec ==
protocol::ChannelConfig::CODEC_VERBATIM) {
Do we still need to support VERBATIM outside of tests? even if not, removing it
can be a separate CL, but it would be nice to clean it up.

[Sergey Ulanov, 2016-08-18 00:32:22]

Description was changed from

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

BUG=638505
==========

to

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505
==========

[Sergey Ulanov, 2016-08-18 00:32:57]

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/audio_sen...
File remoting/protocol/audio_send_stream.h (right):

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/audio_sen...
remoting/protocol/audio_send_stream.h:12: // and sending it to the client.
On 2016/08/17 18:17:30, Jamie wrote:
> Since the API makes no reference to AudioSource or any client classes, perhaps
> it's named too narrowly. How about just calling it AudioStream?

Done
I don't think we will want to use the same interface on both sides, of the
connection. But for now it doesn't matter as we won't need AudioReceiveStream
anytime soon.  AudioStream is also more consistent with VideoStream.

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/ice_conne...
File remoting/protocol/ice_connection_to_client.cc (right):

https://codereview.chromium.org/2254673002/diff/1/remoting/protocol/ice_conne...
remoting/protocol/ice_connection_to_client.cc:38: if (audio_config.codec ==
protocol::ChannelConfig::CODEC_VERBATIM) {
On 2016/08/17 18:17:30, Jamie wrote:
> Do we still need to support VERBATIM outside of tests? even if not, removing
it
> can be a separate CL, but it would be nice to clean it up.

Removed verbatim audio codec in this CL. (verbatim video is still used in
tests).

[Sergey Ulanov, 2016-08-18 00:38:04]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-08-18 00:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps20001
(title: "address feedback")

[commit-bot: I haz the power, 2016-08-18 00:38:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 00:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:49:35]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2016-08-18 18:04:08]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-08-18 18:04:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-08-18 18:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:28:47]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sergey Ulanov, 2016-09-09 18:01:20]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-09 18:01:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps60001
(title: "BUILD files")

[commit-bot: I haz the power, 2016-09-09 18:02:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:29:31]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2016-09-09 19:29:37]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-09 19:29:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-09-09 19:30:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 20:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:09:31]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sergey Ulanov, 2016-09-09 22:56:03]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-09 22:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps100001
(title: "win")

[commit-bot: I haz the power, 2016-09-09 22:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 22:59:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2016-09-09 23:57:54]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-09 23:57:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps120001
(title: "sync")

[commit-bot: I haz the power, 2016-09-09 23:58:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:40:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sergey Ulanov, 2016-09-12 17:46:58]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-12 17:46:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2254673002/#ps140001
(title: "win")

[commit-bot: I haz the power, 2016-09-12 17:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:29:32]

Description was changed from

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505
==========

to

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505
==========

[commit-bot: I haz the power, 2016-09-12 19:29:33]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-12 19:32:07]

Description was changed from

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505
==========

to

==========
Remove dependency on AudioStub in ConnectionToClient

Replaced audio_stub() in ConnectionToClient interface with
CreateAudioStream(). The new method returns AudioSendStream which
doesn't depend on AudioStub. AudioPump class has been moved to
remoting/protocol and it implements AudioSendStream interface for ICE
protocol.
This change makes it possible to implement audio support in
WebrtcConnectionToClient.

Also removed verbatim audio codec as it wasn't used anywhere.

BUG=638505

Committed: https://crrev.com/cd16e206c2182e96019d58d2fa53f6f9d327e6d4
Cr-Commit-Position: refs/heads/master@{#418002}
==========

[commit-bot: I haz the power, 2016-09-12 19:32:08]

Patchset 8 (id:??) landed as
https://crrev.com/cd16e206c2182e96019d58d2fa53f6f9d327e6d4
Cr-Commit-Position: refs/heads/master@{#418002}