Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2254633002: Vendor pyasn1 and pyasn1-modules into build. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Vendor pyasn1 and pyasn1-modules into build. These are needed to flush tsmon metrics. BUG=620610 TBR=sergeyberezin Committed: https://chromium.googlesource.com/chromium/tools/build/+/de534edc1857ce41d33801ceb180ec0780d2ce5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M environment.cfg.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsansome
4 years, 4 months ago (2016-08-17 03:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254633002/1
4 years, 4 months ago (2016-08-17 03:32:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/de534edc1857ce41d33801ceb180ec0780d2ce5a
4 years, 4 months ago (2016-08-17 03:42:25 UTC) #7
Sergey Berezin
4 years, 4 months ago (2016-08-17 21:24:02 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698