Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 225463002: [New Multicolumn] Lay out flow thread again when multicol container height changes. (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Lay out flow thread again when multicol container height changes. The column height may have to be adjusted when the multicol container's height changes, so we need to descend into the RenderMultiColumnFlow thread child of the RenderBlockFlow multicol container when this happens. BUG=359944 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
A LayoutTests/fast/multicol/change-height.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/change-height-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mstensho (USE GERRIT)
6 years, 8 months ago (2014-04-04 07:36:38 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-04 19:01:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/225463002/1
6 years, 8 months ago (2014-04-04 19:01:59 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 19:26:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-04 19:26:51 UTC) #5
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 8 months ago (2014-04-04 19:42:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/225463002/1
6 years, 8 months ago (2014-04-04 19:42:33 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 20:16:22 UTC) #8
Message was sent while issue was closed.
Change committed as 170896

Powered by Google App Engine
This is Rietveld 408576698