Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2254623002: [compositor-worker] Create property tree nodes for proxies. (Closed)

Created:
4 years, 4 months ago by Ian Vollick
Modified:
4 years, 4 months ago
Reviewers:
jaydasika, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, flackr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[compositor-worker] Create property tree nodes for proxies. BUG=430155 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/43daf599823081c97f690df4a1e5431754cfeadc Cr-Commit-Position: refs/heads/master@{#412518}

Patch Set 1 #

Patch Set 2 : Unit test improvement. #

Total comments: 3

Patch Set 3 : Attempt to appease MSVC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M cc/animation/mutable_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 2 chunks +48 lines, -0 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 5 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Ian Vollick
Hey Jayadev, Ali, can you PTAL? This seems not to have been transferred from the ...
4 years, 4 months ago (2016-08-17 02:05:58 UTC) #3
jaydasika
https://codereview.chromium.org/2254623002/diff/20001/cc/trees/property_tree_builder.cc File cc/trees/property_tree_builder.cc (right): https://codereview.chromium.org/2254623002/diff/20001/cc/trees/property_tree_builder.cc#newcode503 cc/trees/property_tree_builder.cc:503: layer->mutable_properties() & MutableProperty::kTransformRelated; Should this be && ? https://codereview.chromium.org/2254623002/diff/20001/cc/trees/property_tree_builder.cc#newcode950 ...
4 years, 4 months ago (2016-08-17 02:38:43 UTC) #6
Ian Vollick
https://codereview.chromium.org/2254623002/diff/20001/cc/trees/property_tree_builder.cc File cc/trees/property_tree_builder.cc (right): https://codereview.chromium.org/2254623002/diff/20001/cc/trees/property_tree_builder.cc#newcode503 cc/trees/property_tree_builder.cc:503: layer->mutable_properties() & MutableProperty::kTransformRelated; On 2016/08/17 at 02:38:43, jaydasika wrote: ...
4 years, 4 months ago (2016-08-17 02:40:28 UTC) #7
jaydasika
lgtm
4 years, 4 months ago (2016-08-17 03:03:40 UTC) #12
ajuma
lgtm too
4 years, 4 months ago (2016-08-17 13:50:26 UTC) #15
Ian Vollick
4 years, 4 months ago (2016-08-17 13:51:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254623002/40001
4 years, 4 months ago (2016-08-17 14:27:16 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 14:30:55 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:32:33 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43daf599823081c97f690df4a1e5431754cfeadc
Cr-Commit-Position: refs/heads/master@{#412518}

Powered by Google App Engine
This is Rietveld 408576698