Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2254603003: Add string for empty label in today extension. (Closed)

Created:
4 years, 4 months ago by Olivier
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add string for empty label in today extension. BUG=633099 Committed: https://crrev.com/9e7a1ebeac57d76644eadae87e805cc0d4304fb9 Cr-Commit-Position: refs/heads/master@{#412519}

Patch Set 1 #

Patch Set 2 : rephrase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/today_extension/strings/ios_today_extension_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Olivier
4 years, 4 months ago (2016-08-17 13:50:35 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 4 months ago (2016-08-17 13:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254603003/20001
4 years, 4 months ago (2016-08-17 13:53:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 14:32:20 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:34:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e7a1ebeac57d76644eadae87e805cc0d4304fb9
Cr-Commit-Position: refs/heads/master@{#412519}

Powered by Google App Engine
This is Rietveld 408576698