Temporary fix to return only the active displays.

Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755
Committed: https://crrev.com/b60f74c0911b362cde913a0bc99cccbaa6d9a9d7
Cr-Commit-Position: refs/heads/master@{#412733}

[malaykeshav, 2016-08-16 22:50:16]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:50:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-08-16 22:51:22]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[malaykeshav, 2016-08-16 22:51:32]

PTAL

[commit-bot: I haz the power, 2016-08-16 23:32:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:32:59]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-17 01:21:08]

lg as a short term solution for m53. please add test. It should work even with a
better solution.

https://codereview.chromium.org/2254603002/diff/1/ash/display/display_manager.h
File ash/display/display_manager.h (right):

https://codereview.chromium.org/2254603002/diff/1/ash/display/display_manager...
ash/display/display_manager.h:432: bool is_updating_display_list_;
nit:  = false;

[malaykeshav, 2016-08-17 22:54:45]

Description was changed from

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

COMPONENT=Ash, Display Manager
BUG=632755
==========

to

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Ash unit test
BUG=632755
==========

[malaykeshav, 2016-08-17 22:55:04]

Description was changed from

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Ash unit test
BUG=632755
==========

to

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755
==========

[malaykeshav, 2016-08-17 22:55:14]

PTAL.
Added unit tests

[oshima, 2016-08-17 23:24:42]

then lgtm

https://codereview.chromium.org/2254603002/diff/20001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2254603002/diff/20001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager_unittest.cc:343: CreateDisplayInfo(1,
gfx::Rect(0, 0, 1280, 720));
can you make this internal display?

const int64_t internal_display_id =
     test::DisplayManagerTestApi().SetFirstDisplayAsInternalDisplay();

[malaykeshav, 2016-08-18 00:35:07]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:35:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 01:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:32:15]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-08-18 02:31:26]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-08-18 02:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2254603002/#ps40001
(title: "Temporary fix to return only the active displays.")

[commit-bot: I haz the power, 2016-08-18 02:32:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 04:00:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-18 04:03:45]

Description was changed from

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755
==========

to

==========
Temporary fix to return only the active displays.

During the execution of |UpdateDisplaysWith|, |active_display_list|
is being modified and temporarily contains displays that have been
removed.This causes a crash during SetBound operations for some display
change observers that use the removed displays as an active display.

- Adds unit tests that fails without the fix in this patchset.

COMPONENT=Ash, Display Manager, Panel Layout Manager, Ash unit test
BUG=632755

Committed: https://crrev.com/b60f74c0911b362cde913a0bc99cccbaa6d9a9d7
Cr-Commit-Position: refs/heads/master@{#412733}
==========

[commit-bot: I haz the power, 2016-08-18 04:03:46]

Patchset 3 (id:??) landed as
https://crrev.com/b60f74c0911b362cde913a0bc99cccbaa6d9a9d7
Cr-Commit-Position: refs/heads/master@{#412733}