Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 22546003: Rollback of r16071 in trunk branch. (Closed)

Created:
7 years, 4 months ago by danno
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Version 3.20.14.1: Rollback of r16071 in trunk branch. Un-revert "Implement simple effect typing for variables" and "Handle switch effects" R=dslomov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -615 lines) Patch
M src/ast.h View 8 chunks +4 lines, -25 lines 0 comments Download
D src/effects.h View 1 chunk +0 lines, -361 lines 0 comments Download
M src/splay-tree.h View 3 chunks +3 lines, -11 lines 0 comments Download
M src/splay-tree-inl.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/types.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/typing.h View 3 chunks +0 lines, -17 lines 0 comments Download
M src/typing.cc View 23 chunks +58 lines, -178 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/zone-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
7 years, 4 months ago (2013-08-07 09:45:07 UTC) #1
Dmitry Lomov (no reviews)
lgtm
7 years, 4 months ago (2013-08-07 09:47:33 UTC) #2
danno
7 years, 4 months ago (2013-08-07 09:48:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698