Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2254593003: Remove purgedSize and purgeableSize from TypeStatistic (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 3 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@SharedBuffer_DoNotUnlock
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove purgedSize and purgeableSize from TypeStatistic and ResourceTypeStat They are unused after https://codereview.chromium.org/2253853002/ and thus this CL removes them from MemoryCache::TypeStatistic and WebCache::ResourceTypeStat. This CL also fixes compile errors when MEMORY_CACHE_STATS is enabled. BUG=603791 Committed: https://crrev.com/022d502a9aec8930029c9c3b05eedb4144308f14 Cr-Commit-Position: refs/heads/master@{#415602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/WebCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebCache.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
haraken
LGTM
4 years, 4 months ago (2016-08-17 09:11:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254593003/1
4 years, 3 months ago (2016-08-31 06:16:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/250028)
4 years, 3 months ago (2016-08-31 06:22:42 UTC) #7
hiroshige
tkent@, could you take a look as a public/ OWNER?
4 years, 3 months ago (2016-08-31 06:41:06 UTC) #9
tkent
lgtm. I guess you saw presubmit warnings about printf usage. Please remove printfs (in another ...
4 years, 3 months ago (2016-08-31 06:48:11 UTC) #11
hiroshige
> I guess you saw presubmit warnings about printf usage. Please remove printfs > (in ...
4 years, 3 months ago (2016-08-31 07:10:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254593003/1
4 years, 3 months ago (2016-08-31 10:18:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 10:23:31 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 10:24:56 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/022d502a9aec8930029c9c3b05eedb4144308f14
Cr-Commit-Position: refs/heads/master@{#415602}

Powered by Google App Engine
This is Rietveld 408576698