[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is used in the AnimationWorkletThreadTest (which is a clone of the CompositorWorkerThreadTest).

BUG=567358
Committed: https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622
Cr-Commit-Position: refs/heads/master@{#414517}

[ikilpatrick, 2016-08-16 23:30:26]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-08-16 23:42:47]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 23:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 01:15:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ikilpatrick, 2016-08-17 01:33:10]

Description was changed from

==========
[WIP][worklets] Introduce AnimationWorkletGlobalScope.

BUG=567358
==========

to

==========
[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be
logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is
used in the AnimationWorkletThreadTest (which is a clone of the
CompositorWorkerThreadTest).

BUG=567358
==========

[ikilpatrick, 2016-08-17 01:33:55]

ikilpatrick@chromium.org changed reviewers:
+ flackr@chromium.org, haraken@chromium.org, mkwst@chromium.org,
nhiroki@chromium.org

[ikilpatrick, 2016-08-17 01:37:14]

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp:35:
RefPtr<SecurityOrigin> securityOrigin =
SecurityOrigin::create(startupData->m_scriptURL);
@mike - for the MainThreadWorkletGlobalScope we just use the parent documents
SecurityOrigin; is transferring privileges here equivilent? Or should we be
making an isolatedCopy of the SecurityOrigin?

[nhiroki, 2016-08-17 05:56:57]

lgtm

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:22:
#include "wtf/RefPtr.h"
Following inclusions might not be necessary.

"core/loader/WorkerThreadableLoader.h"
"core/workers/WorkerLoaderProxy.h"
"core/workers/WorkerScriptLoader.h"
"platform/network/ContentSecurityPolicyParsers.h"
"public/platform/WebScheduler.h"
"public/platform/WebURLRequest.h"

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp:52:
TestAnimationWorkletReportingProxy() { }
nit: { } -> {}

[haraken, 2016-08-17 06:07:25]

LGTM

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:33: {

Shall we add DCHECK(!m_thread) ?

[ikilpatrick, 2016-08-22 18:32:24]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 18:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[flackr, 2016-08-22 18:41:14]

Looks good, one question about how we will connect this with the
CompositorProxyClient. Maybe we need a TODO for this plumbing.

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
(left):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp:119:
provideCompositorProxyClientTo(clients, new TestCompositorProxyClient);
Can you remind me how we will eventually get the CompositorProxyClient instance
plumbed over to the worklet? Can it be sent as part of WorkerClients and this
code re-added later or do we have to find another way to send it over?

[ikilpatrick, 2016-08-22 19:07:32]

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:22:
#include "wtf/RefPtr.h"
On 2016/08/17 05:56:57, nhiroki wrote:
> Following inclusions might not be necessary.
> 
> "core/loader/WorkerThreadableLoader.h"
> "core/workers/WorkerLoaderProxy.h"
> "core/workers/WorkerScriptLoader.h"
> "platform/network/ContentSecurityPolicyParsers.h"
> "public/platform/WebScheduler.h"
> "public/platform/WebURLRequest.h"

Done.

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:33: {
On 2016/08/17 06:07:25, haraken wrote:
> 
> Shall we add DCHECK(!m_thread) ?

Done.

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
(left):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp:119:
provideCompositorProxyClientTo(clients, new TestCompositorProxyClient);
On 2016/08/22 18:41:14, flackr wrote:
> Can you remind me how we will eventually get the CompositorProxyClient
instance
> plumbed over to the worklet? Can it be sent as part of WorkerClients and this
> code re-added later or do we have to find another way to send it over?

Can just be passed in here on worklet thread start. Worklets don't have
workerclients yet (as wasn't initially needed) could:
1) Re-add this here?
2) Add todo inside AnimationWorkletThread::createGlobalScope to hook up worker
clients?

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
(right):

https://codereview.chromium.org/2254593002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp:52:
TestAnimationWorkletReportingProxy() { }
On 2016/08/17 05:56:57, nhiroki wrote:
> nit: { } -> {}

Done.

[ikilpatrick, 2016-08-22 20:14:23]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 20:15:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[flackr, 2016-08-22 20:17:48]

lgtm

[commit-bot: I haz the power, 2016-08-22 21:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:56:39]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ikilpatrick, 2016-08-23 00:25:34]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 00:26:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 03:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 03:13:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ikilpatrick, 2016-08-23 17:59:46]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 18:00:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 19:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:11:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ikilpatrick, 2016-08-23 19:41:25]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 19:42:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 21:53:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ikilpatrick, 2016-08-25 17:53:00]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:53:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:56:52]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2016-08-25 20:04:50]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-08-25 20:04:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, nhiroki@chromium.org, flackr@chromium.org
Link to the patchset: https://codereview.chromium.org/2254593002/#ps180001
(title: "Add super call to WorkletGlobalScope::dispose()")

[commit-bot: I haz the power, 2016-08-25 20:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:12:44]

Description was changed from

==========
[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be
logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is
used in the AnimationWorkletThreadTest (which is a clone of the
CompositorWorkerThreadTest).

BUG=567358
==========

to

==========
[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be
logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is
used in the AnimationWorkletThreadTest (which is a clone of the
CompositorWorkerThreadTest).

BUG=567358
==========

[commit-bot: I haz the power, 2016-08-25 20:12:45]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-08-25 20:14:47]

Description was changed from

==========
[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be
logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is
used in the AnimationWorkletThreadTest (which is a clone of the
CompositorWorkerThreadTest).

BUG=567358
==========

to

==========
[worklets] Introduce AnimationWorkletGlobalScope and ThreadedWorkletGlobalScope

The ThreadedWorkletGlobalScope is simpler than a WorkerGlobalScope as
 - It doesn't need to report exceptions to the main thread they can just be
logged to the console.

AnimationWorkletGlobalScope doesn't have anything on it at the moment, but is
used in the AnimationWorkletThreadTest (which is a clone of the
CompositorWorkerThreadTest).

BUG=567358

Committed: https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622
Cr-Commit-Position: refs/heads/master@{#414517}
==========

[commit-bot: I haz the power, 2016-08-25 20:14:49]

Patchset 10 (id:??) landed as
https://crrev.com/dbc47ca435e2b5aba33485cbd62a75dd3683b622
Cr-Commit-Position: refs/heads/master@{#414517}