cc : Delete LayerImpl::transform

cc : Delete LayerImpl::transform

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a
Cr-Commit-Position: refs/heads/master@{#412739}

[jaydasika, 2016-08-16 23:01:13]

Description was changed from

==========
cc : Delete LayerImpl::transform

BUG=638297
==========

to

==========
cc : Delete LayerImpl::transform

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-16 23:08:17]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-08-16 23:08:45]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[jaydasika, 2016-08-16 23:08:46]

PTAL

[commit-bot: I haz the power, 2016-08-16 23:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 00:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:20:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2016-08-17 13:27:46]

The CompositorWorker-related test failures look real.

https://codereview.chromium.org/2254543004/diff/1/cc/layers/layer_impl_unitte...
File cc/layers/layer_impl_unittest.cc (left):

https://codereview.chromium.org/2254543004/diff/1/cc/layers/layer_impl_unitte...
cc/layers/layer_impl_unittest.cc:174:
root->OnTransformAnimated(arbitrary_transform));
Animating transform should still cause damage. Does this test fail if we keep
this line?

https://codereview.chromium.org/2254543004/diff/1/cc/test/layer_tree_json_par...
File cc/test/layer_tree_json_parser_unittest.cc (left):

https://codereview.chromium.org/2254543004/diff/1/cc/test/layer_tree_json_par...
cc/test/layer_tree_json_parser_unittest.cc:38: layer_impl->transform(),
layer->transform()));
I think we need to continue to include a transform in LayerTreeAsJson, just like
we include opacity even though that's not part of LayerImpl anymore (since in
cc/test/data we do have json representations of trees with non-trivial
transforms).

[jaydasika, 2016-08-17 18:44:23]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-08-17 19:40:00]

https://codereview.chromium.org/2254543004/diff/1/cc/layers/layer_impl_unitte...
File cc/layers/layer_impl_unittest.cc (left):

https://codereview.chromium.org/2254543004/diff/1/cc/layers/layer_impl_unitte...
cc/layers/layer_impl_unittest.cc:174:
root->OnTransformAnimated(arbitrary_transform));
On 2016/08/17 13:27:46, ajuma wrote:
> Animating transform should still cause damage. Does this test fail if we keep
> this line?

Done.

https://codereview.chromium.org/2254543004/diff/1/cc/test/layer_tree_json_par...
File cc/test/layer_tree_json_parser_unittest.cc (left):

https://codereview.chromium.org/2254543004/diff/1/cc/test/layer_tree_json_par...
cc/test/layer_tree_json_parser_unittest.cc:38: layer_impl->transform(),
layer->transform()));
On 2016/08/17 13:27:46, ajuma wrote:
> I think we need to continue to include a transform in LayerTreeAsJson, just
like
> we include opacity even though that's not part of LayerImpl anymore (since in
> cc/test/data we do have json representations of trees with non-trivial
> transforms).

Done.

[jaydasika, 2016-08-17 19:40:12]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-08-17 20:26:34]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:26:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-08-17 20:27:25]

Use test properties transform in LayerTreeAsJson

[ajuma, 2016-08-17 20:30:31]

Thanks, lgtm

[jaydasika, 2016-08-17 20:32:10]

vollick : Can you review changes in platform/graphics ?

[Ian Vollick, 2016-08-17 20:42:35]

On 2016/08/17 20:32:10, jaydasika wrote:
> vollick : Can you review changes in platform/graphics ?

lgtm!

[commit-bot: I haz the power, 2016-08-17 22:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:38:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jaydasika, 2016-08-17 22:39:25]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 04:06:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-18 04:08:37]

Description was changed from

==========
cc : Delete LayerImpl::transform

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Delete LayerImpl::transform

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a
Cr-Commit-Position: refs/heads/master@{#412739}
==========

[commit-bot: I haz the power, 2016-08-18 04:08:38]

Patchset 5 (id:??) landed as
https://crrev.com/10d43fc63e60431d6edb5d9a739cfe5ca40ce95a
Cr-Commit-Position: refs/heads/master@{#412739}